Fix mutation function in JoinStatusTests #92534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes `mutateJoinStatus()` would fail to return a different object, e.g. if the message was very short. Also in case 4 it was mutating both the message and the age, but should not have been mutating the message.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
reviewed
Dec 23, 2022
server/src/test/java/org/elasticsearch/cluster/coordination/JoinStatusTests.java
Show resolved
Hide resolved
pxsalehi
reviewed
Dec 23, 2022
| randomAlphaOfLength(30), | ||
| randomNonNegativeTimeValue() | ||
| originalJoinStatus.message(), | ||
| ESTestCase.randomValueOtherThan(originalJoinStatus.age(), this::randomNonNegativeTimeValue) |
There was a problem hiding this comment.
Is the ESTestCase necessary here?
There was a problem hiding this comment.
No, not sure why IntelliJ put that there 😕
pxsalehi
approved these changes
Dec 23, 2022
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 23, 2022
Sometimes `mutateJoinStatus()` would fail to return a different object, e.g. if the message was very short. Also in case 4 it was mutating both the message and the age, but should not have been mutating the message.
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
mutateJoinStatus()would fail to return a different object, e.g. if the message was very short. Also in case 4 it was mutating both the message and the age, but should not have been mutating the message.