Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.6] Fix mutation function in JoinStatusTests (#92534) #92545

Merged
merged 1 commit into from
Dec 23, 2022
Merged

[8.6] Fix mutation function in JoinStatusTests (#92534) #92545

merged 1 commit into from
Dec 23, 2022
+3 −3

Conversation

DaveCTurner
Copy link
Contributor

Backports the following commits to 8.6:

@DaveCTurner
Fix mutation function in JoinStatusTests (elastic#92534)
d4176c4 
Sometimes `mutateJoinStatus()` would fail to return a different object,
e.g. if the message was very short. Also in case 4 it was mutating both
the message and the age, but should not have been mutating the message.
@DaveCTurner DaveCTurner added :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Dec 23, 2022
@elasticsearchmachine elasticsearchmachine mentioned this pull request Dec 23, 2022
Merged
@elasticsearchmachine elasticsearchmachine merged commit 8524372 into elastic:8.6 Dec 23, 2022
@DaveCTurner DaveCTurner deleted the backport/8.6/pr-92534 branch December 23, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveCTurner @elasticsearchmachine