Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutation function in JoinStatusTests #92534

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Fix mutation function in JoinStatusTests #92534

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e8d238
Fix mutation function in JoinStatusTests
DaveCTurner Dec 22, 2022
5734914
Merge branch 'main' into 2022-12-22-JoinStatusTests-did-not-mutate
DaveCTurner Dec 23, 2022
fbdb14a
Unnecessary qualifier
DaveCTurner Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/src/test/java/org/elasticsearch/cluster/coordination/JoinStatusTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ private JoinStatus mutateJoinStatus(JoinStatus originalJoinStatus) {
return new JoinStatus(
originalJoinStatus.remoteNode(),
originalJoinStatus.term(),
randomAlphaOfLengthBetween(0, 30),
randomValueOtherThan(originalJoinStatus.message(), () -> randomAlphaOfLengthBetween(0, 30)),
originalJoinStatus.age()
);
}
case 3 -> {
return new JoinStatus(
originalJoinStatus.remoteNode(),
originalJoinStatus.term(),
randomAlphaOfLength(30),
randomNonNegativeTimeValue()
pxsalehi marked this conversation as resolved.
Show resolved Hide resolved
originalJoinStatus.message(),
ESTestCase.randomValueOtherThan(originalJoinStatus.age(), this::randomNonNegativeTimeValue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ESTestCase necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not sure why IntelliJ put that there 😕

);
}
case 4 -> {
Expand Down