Chunked encoding for cluster state API #92285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
19 tasks
|
NB most of these changes are just to add support for XContent fragments throughout. Kind of noisy. I could make it a separate API instead of adding a boolean parameter, maybe that would be nicer. |
|
#92534 will fix the failure; @elasticmachine please run elasticsearch-ci/part-1 |
|
@original-brownbear I've merged this with |
original-brownbear
approved these changes
Dec 30, 2022
| metrics.contains(Metric.CUSTOMS) | ||
| ? Iterators.flatMap( | ||
| customs.entrySet().iterator(), | ||
| cursor -> Iterators.concat( |
There was a problem hiding this comment.
NIT: could use org.elasticsearch.common.xcontent.ChunkedToXContentHelper#wrapWithObject here to shorten this a little
There was a problem hiding this comment.
++ thanks, see c5bc46d
| * Response listener for REST requests which dispatches the serialization of the response off of the thread on which the response was | ||
| * received, since that thread is often a transport thread and XContent serialization might be expensive. | ||
| */ | ||
| public class DispatchingRestToXContentListener<Response extends ToXContentObject> extends RestActionListener<Response> { |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 31, 2022
The cluster reroute API (optionally) returns the cluster state in its response, which can therefore be rather large. elastic#92285 enables a chunked encoding of the cluster state, and this commit adjusts the reroute API to make use of this encoding too.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 24, 2023
The cluster reroute API (optionally) returns the cluster state in its response, which can therefore be rather large. #92285 enables a chunked encoding of the cluster state, and this commit adjusts the reroute API to make use of this encoding too.
This was referenced Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #89838