Add unit tests for indices.recovery.max_bytes_per_sec default values #83261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine run elasticsearch-ci/bwc |
idegtiarenko
approved these changes
Jan 28, 2022
henningandersen
approved these changes
Jan 28, 2022
| final ByteSizeValue totalPhysicalMemory = new ByteSizeValue(OsProbe.getInstance().getTotalPhysicalMemorySize()); | ||
| final ByteSizeValue totalPhysicalMemory = TOTAL_PHYSICAL_MEMORY_OVERRIDING_TEST_SETTING.exists(s) | ||
| ? TOTAL_PHYSICAL_MEMORY_OVERRIDING_TEST_SETTING.get(s) | ||
| : new ByteSizeValue(OsProbe.getInstance().getTotalPhysicalMemorySize()); |
There was a problem hiding this comment.
Could we instead let this value be the default value of the setting?
| if (JavaVersion.current().compareTo(JavaVersion.parse("14")) < 0) { | ||
| JavaVersion javaVersion = JAVA_VERSION_OVERRIDING_TEST_SETTING.exists(s) | ||
| ? JAVA_VERSION_OVERRIDING_TEST_SETTING.get(s) | ||
| : JavaVersion.current(); |
There was a problem hiding this comment.
Could we instead let this value be the default value of the setting?
| final ByteSizeValue random = randomByteSizeValue(); | ||
| assertThat( | ||
| "Data nodes that are not dedicated to cold/frozen should use the defined rate limit when set", | ||
| nodeRecoverySettings().withRole(randomFrom("data", "data_hot", "data_warm", "data_content")) |
There was a problem hiding this comment.
Can we randomly add either data_cold or data_frozen (or both) to the set of roles here?
tlrx
added
auto-backport-and-merge
auto-merge-without-approval
|
Thanks Ievgen & Henning |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jan 28, 2022
…lastic#83261) `indices.recovery.max_bytes_per_sec` has a default value that depends on multiple criteria that are well documented but not unit tested. This pull request introduces unit tests that verifies the current behavior so that future changes like elastic#82819 are less likely to break things.
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jan 28, 2022
…lastic#83261) `indices.recovery.max_bytes_per_sec` has a default value that depends on multiple criteria that are well documented but not unit tested. This pull request introduces unit tests that verifies the current behavior so that future changes like elastic#82819 are less likely to break things.
tlrx
added a commit
that referenced
this pull request
Jan 31, 2022
…83261) (#83283) `indices.recovery.max_bytes_per_sec` has a default value that depends on multiple criteria that are well documented but not unit tested. This pull request introduces unit tests that verifies the current behavior so that future changes like #82819 are less likely to break things. Backport of #83261
tlrx
added a commit
that referenced
this pull request
Jan 31, 2022
…83261) (#83289) `indices.recovery.max_bytes_per_sec` has a default value that depends on multiple criteria that are well documented but not unit tested. This pull request introduces unit tests that verifies the current behavior so that future changes like #82819 are less likely to break things. Backport of #83261
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jan 31, 2022
* upstream/master: (100 commits) Avoid duplicate _type fields in v7 compat layer (elastic#83239) Bump bundled JDK to 17.0.2+8 (elastic#83243) [DOCS] Correct header syntax (elastic#83275) Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261) [DOCS] Add note that write indices are not replicated (elastic#82997) Add notes on indexing to kNN search guide (elastic#83188) Fix get-snapshot-api :docs:integTest (elastic#83273) FilterPathBasedFilter support match fieldname with dot (elastic#83178) Fix compilation issues in example-plugins (elastic#83258) fix ClusterStateListener javadoc (elastic#83246) Speed up Building Indices Lookup in Metadata (elastic#83241) Mute whole suite for elastic#82502 (elastic#83252) Make PeerFinder log messages happier (elastic#83222) [Docs] Add supported _terms_enum field types (elastic#83244) Add an aggregator for IPv4 and IPv6 subnets (elastic#82410) [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217) Update test-failure Issue Template to include "needs:triage" label elastic#83226 Add an index->step cache to the PolicyStepsRegistry (elastic#82316) Improve support for joda datetime to java datetime transition in Painless (elastic#83099) Fix joda migration for week based methods in Painless (elastic#83232) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indices.recovery.max_bytes_per_sechas a default value that depends on multiple criteria that are well documented but not unit tested. This pull request introduces unit tests that verifies the current behavior so that future changes like #82819 are less likely to break things.