Fix compilation issues in example-plugins #83258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>non-issue
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pugnascotia
removed
the
auto-merge-without-approval
pugnascotia
added
the
auto-merge-without-approval
|
Sorry for the noise, just catching up on this. I'm curious about why we didn't get these errors on CI when running it on the PR that introduced this change (i.e. #78621) |
|
Looks like CI only builds the example plugins if the directory has changed, or any of the build related directories at the top-level have changed. But that's clearly not working because the example plugins depend on the server code, so we need to look at changing that. cc @mark-vieira |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Jan 28, 2022
Commit 051e1d6 broke a couple of the example plugins project, so get them working again.
This was referenced Jan 28, 2022
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Jan 28, 2022
Commit 051e1d6 broke a couple of the example plugins project, so get them working again.
|
@pugnascotia thanks for fixing, I don't think this needs to go to 8.0 and 7.17 though since the change causing this was only merged to 8.1 and we don't intend to backport there. |
|
@cbuescher OK, I close the backport PRs. I was partly doing that because the other branches also contain a typo in the example plugins build file, but I'll fix that separately. |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jan 31, 2022
* upstream/master: (100 commits) Avoid duplicate _type fields in v7 compat layer (elastic#83239) Bump bundled JDK to 17.0.2+8 (elastic#83243) [DOCS] Correct header syntax (elastic#83275) Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261) [DOCS] Add note that write indices are not replicated (elastic#82997) Add notes on indexing to kNN search guide (elastic#83188) Fix get-snapshot-api :docs:integTest (elastic#83273) FilterPathBasedFilter support match fieldname with dot (elastic#83178) Fix compilation issues in example-plugins (elastic#83258) fix ClusterStateListener javadoc (elastic#83246) Speed up Building Indices Lookup in Metadata (elastic#83241) Mute whole suite for elastic#82502 (elastic#83252) Make PeerFinder log messages happier (elastic#83222) [Docs] Add supported _terms_enum field types (elastic#83244) Add an aggregator for IPv4 and IPv6 subnets (elastic#82410) [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217) Update test-failure Issue Template to include "needs:triage" label elastic#83226 Add an index->step cache to the PolicyStepsRegistry (elastic#82316) Improve support for joda datetime to java datetime transition in Painless (elastic#83099) Fix joda migration for week based methods in Painless (elastic#83232) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 051e1d6 broke a couple of the example plugins
project, so get them working again.