Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate _type fields in v7 compat layer #83239

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Avoid duplicate _type fields in v7 compat layer #83239

merged 2 commits into from
Jan 29, 2022

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jan 28, 2022

@ywelsch ywelsch added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.1.0 labels Jan 28, 2022
@ywelsch ywelsch requested a review from jtibshirani January 28, 2022 07:30
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jan 28, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ywelsch

jtibshirani
jtibshirani approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 28, 2022

@elasticmachine update branch

@ywelsch ywelsch merged commit 87ee045 into elastic:master Jan 29, 2022
@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 29, 2022

Thanks @romseygeek and @jtibshirani!

@ywelsch ywelsch mentioned this pull request Jan 29, 2022
Closed
32 tasks
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jan 31, 2022
@weizijun
Merge branch 'upstream/master' into rollup-index-improvement
b996c80 
* upstream/master: (100 commits)
  Avoid duplicate _type fields in v7 compat layer (elastic#83239)
  Bump bundled JDK to 17.0.2+8 (elastic#83243)
  [DOCS] Correct header syntax (elastic#83275)
  Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261)
  [DOCS] Add note that write indices are not replicated (elastic#82997)
  Add notes on indexing to kNN search guide (elastic#83188)
  Fix get-snapshot-api :docs:integTest (elastic#83273)
  FilterPathBasedFilter support match fieldname with dot (elastic#83178)
  Fix compilation issues in example-plugins (elastic#83258)
  fix ClusterStateListener javadoc (elastic#83246)
  Speed up Building Indices Lookup in Metadata (elastic#83241)
  Mute whole suite for elastic#82502 (elastic#83252)
  Make PeerFinder log messages happier (elastic#83222)
  [Docs] Add supported _terms_enum field types (elastic#83244)
  Add an aggregator for IPv4 and IPv6 subnets (elastic#82410)
  [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217)
  Update test-failure Issue Template to include "needs:triage" label elastic#83226
  Add an index->step cache to the PolicyStepsRegistry (elastic#82316)
  Improve support for joda datetime to java datetime transition in Painless (elastic#83099)
  Fix joda migration for week based methods in Painless (elastic#83232)
  ...

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywelsch @elasticmachine @romseygeek @jtibshirani