Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix 70_time_series/default sort yaml test failures #83217

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

csoulios
Copy link
Contributor

@csoulios csoulios commented Jan 27, 2022

Fixes test failures like: https://gradle-enterprise.elastic.co/s/gkjt33zqmnjuu

The test executes a match_all query that returns all results in the index. Since _score for all search results is 1, the test erroneously assumed that results are returned in the order documents are stored on disk.

However, if a shard has multiple segments, the results order can be unpredictable. This PR fixes the test by explicitly setting the sort parameter for the query.

@csoulios csoulios added >test-failure Triaged test failures from CI :StorageEngine/TSDB You know, for Metrics v8.1.0 labels Jan 27, 2022
@csoulios csoulios requested a review from martijnvg January 27, 2022 15:47
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 27, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@csoulios csoulios added >test Issues or PRs that are addressing/adding tests and removed >test-failure Triaged test failures from CI labels Jan 27, 2022
@csoulios
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@csoulios csoulios merged commit 6dba334 into elastic:master Jan 28, 2022
@csoulios csoulios deleted the fix-tsid-ul-order branch January 28, 2022 08:20
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jan 31, 2022
* upstream/master: (100 commits)
  Avoid duplicate _type fields in v7 compat layer (elastic#83239)
  Bump bundled JDK to 17.0.2+8 (elastic#83243)
  [DOCS] Correct header syntax (elastic#83275)
  Add unit tests for indices.recovery.max_bytes_per_sec default values (elastic#83261)
  [DOCS] Add note that write indices are not replicated (elastic#82997)
  Add notes on indexing to kNN search guide (elastic#83188)
  Fix get-snapshot-api :docs:integTest (elastic#83273)
  FilterPathBasedFilter support match fieldname with dot (elastic#83178)
  Fix compilation issues in example-plugins (elastic#83258)
  fix ClusterStateListener javadoc (elastic#83246)
  Speed up Building Indices Lookup in Metadata (elastic#83241)
  Mute whole suite for elastic#82502 (elastic#83252)
  Make PeerFinder log messages happier (elastic#83222)
  [Docs] Add supported _terms_enum field types (elastic#83244)
  Add an aggregator for IPv4 and IPv6 subnets (elastic#82410)
  [CI] Fix 70_time_series/default sort yaml test failures (elastic#83217)
  Update test-failure Issue Template to include "needs:triage" label elastic#83226
  Add an index->step cache to the PolicyStepsRegistry (elastic#82316)
  Improve support for joda datetime to java datetime transition in Painless (elastic#83099)
  Fix joda migration for week based methods in Painless (elastic#83232)
  ...

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/TransportRollupAction.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants