-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY #28813
Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY #28813
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
/package |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/test |
1 similar comment
/test |
We must update the E2E code to support this rename, i.e. here https://github.com/elastic/e2e-testing/blob/87be9250d36ed05a80d211f245eb52794d060478/internal/versions_test.go#L442 |
Good catch, this will only be needed for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should have a changelog note in the breaking change section. I'm sure there is plenty of automation out there that will require updates. Here's what we have in the download logs (last 90d) for "arm64.tar.gz" beat artifacts.
I see Elastic Agent in this list. Have you checked if Elastic Agent needs an update or any of Elastic Cloud references this artifact name?
Top values of agent.raw | Count of records |
---|---|
curl/7.29.0 | 82,915 |
Cloud-CDN-Google (GFE/2.0) | 17,492 |
curl/7.58.0 | 3,042 |
Mozilla/5.0 (compatible; bingbot/2.0; http://www.bing.com/bingbot.htm) | 2,221 |
Go-http-client/2.0 | 2,115 |
Beat elastic-agent v8.0.0 | 1,398 |
Beat elastic-agent v7.16.0 | 660 |
curl/7.76.1 | 584 |
curl/7.61.1 | 579 |
Mozilla/5.0 (iPhone; CPU iPhone OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53 (compatible; bingbot/2.0; http://www.bing.com/bingbot.htm) | 545 |
Wget/1.14 (linux-gnu) | 465 |
Beat elastic-agent v7.15.2 | 365 |
Gradle/7.1 (Linux;5.4.0-1055-aws;aarch64) (Private Build;1.8.0_292;25.292-b10) | 264 |
Mozilla/5.0 (compatible; AhrefsSiteAudit/6.1; http://ahrefs.com/robot/) | 257 |
Mozilla/5.0 (compatible; AhrefsBot/7.0; http://ahrefs.com/robot/) | 214 |
Gradle/7.2 (Linux;5.4.0-1058-aws;aarch64) (Eclipse Foundation;11.0.12;11.0.12 7) | 210 |
Gradle/7.2 (Linux;5.4.0-1057-aws;aarch64) (Eclipse Foundation;11.0.12;11.0.12 7) | 198 |
Salt/3003.2 http.query() | 192 |
curl/7.68.0 | 184 |
Gradle/7.2 (Linux;5.11.0-1020-aws;aarch64) (Eclipse Foundation;11.0.12;11.0.12 7) | 168 |
Gradle/7.2 (Linux;5.4.0-1057-aws;aarch64) (Private Build;1.8.0_292;25.292-b10) | 168 |
Mozilla/5.0 (Linux; Android 7.0;) AppleWebKit/537.36 (KHTML, like Gecko) Mobile Safari/537.36 (compatible; PetalBot; https://webmaster.petalsearch.com/site/petalbot) | 165 |
curl/7.64.1 | 152 |
Mozilla/5.0 (iPhone; CPU iPhone OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53 BingPreview/1.0b | 151 |
Gradle/7.2 (Linux;5.4.0-1056-aws;aarch64) (Private Build;1.8.0_292;25.292-b10) | 144 |
Salt/3003.3 http.query() | 144 |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/534 (KHTML, like Gecko) BingPreview/1.0b | 117 |
ansible-httpget | 111 |
Gradle/7.1 (Linux;5.4.0-1054-aws;aarch64) (Private Build;1.8.0_292;25.292-b10) | 108 |
Wget/1.20.3 (linux-gnu) | 99 |
Salt/3003.1 http.query() | 87 |
Gradle/7.1 (Linux;5.4.0-1056-aws;aarch64) (Private Build;1.8.0_292;25.292-b10) | 84 |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36 | 69 |
curl/7.78.0 | 68 |
httpx - Open-source project (github.com/projectdiscovery/httpx) | 68 |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36 | 65 |
Salt/3004 http.query() | 62 |
Python-urllib/3.7 | 60 |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 | 50 |
Beat elastic-agent v7.15.0 | 47 |
Screaming Frog SEO Spider/15.2 | 47 |
Wget/1.19.4 (linux-gnu) | 42 |
Mozilla/5.0 (X11 | 41 |
Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5X Build/MMB29P) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.119 Mobile Safari/537.36 (compatible; Googlebot/2.1; http://www.google.com/bot.html) | 40 |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36 | 37 |
Beat elastic-agent v7.14.1 | 36 |
Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; InfoPath.3; wbx 1.0.0; systeccloud 3.5.1; Zoom 3.6.0) | 36 |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 | 34 |
Mozilla/5.0 (Linux; Android) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36 | 33 |
Magic Browser | 30 |
Other | 1,604 |
Does it apply to |
Debian uses "arm64" as their naming convention for artifacts targeting aarch64 (https://wiki.debian.org/Arm64Port). That's why those files have that name. Does the rest of the stack follow the Debian convention for .deb?
|
@andrewkroh good point. Yes they do: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT/elasticsearch?x-elastic-no-kpi=true
|
I'd say that is most common to find |
…in-the-package-binareis * upstream/master: allows disable pod events enrichment with deployment name (elastic#28521) Remove Docker input from Filebeat (elastic#28817) [breaking] Make default_field: false the default for all fields (elastic#28596) Osquerybeat: Improve osquery client connect code (elastic#28848) Add crawler metrics into the stats metricset for Enterprise Search (elastic#28790) Remove the now deprecated appsearch module from metricbeat (elastic#28850) Remove Beat generators (elastic#28816) chore: upload files to Google Storage when they exist (elastic#28836) Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812) Deprecate generating custom Beats (elastic#28814) [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094) Osquerybeat: Fix restart flags after previously bad config (elastic#28827) Force ECS and JSON logging for libbeat/logp (elastic#28573) Filebeat: Error on startup for unconfigured module (elastic#28818) Deprecate log input in favour of filestream (elastic#28623) Fix some spelling mistakes (elastic#28080)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming due diligence has been done to update release-manager, download pages, and check with other Elastic teams.
@elasticmachine, run elasticsearch-ci/docs |
Changes for
Regarding the Elastic Cloud, I guess they only use docker images from a docker registry. I didn't change the For the record, this PR changes the above and the gsutil ls -r gs://beats-ci-artifacts/pull-requests/pr-28813 | grep 'cloud'
gs://beats-ci-artifacts/pull-requests/pr-28813/elastic-agent/elastic-agent-cloud-8.1.0-SNAPSHOT-linux-amd64.docker.tar.gz
gs://beats-ci-artifacts/pull-requests/pr-28813/elastic-agent/elastic-agent-cloud-8.1.0-SNAPSHOT-linux-amd64.docker.tar.gz.sha512
gs://beats-ci-artifacts/pull-requests/pr-28813/elastic-agent/elastic-agent-cloud-8.1.0-SNAPSHOT-linux-arm64.docker.tar.gz
gs://beats-ci-artifacts/pull-requests/pr-28813/elastic-agent/elastic-agent-cloud-8.1.0-SNAPSHOT-linux-arm64.docker.tar.gz.sha512 I'll wait for the Infra Release team to answer if that's also needed. |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Victor 👍
Thanks Maxime, as we have agreed, I'll move forward and merge this PR. The backport to 8.0 will happen but the merge will bee done after we know all the changes worked as expected. Thanks again |
Heads ups, we have decided to revert this change for the time being as |
…k-version-after-8-0-creation * upstream/master: (69 commits) Update stale config following (elastic#30082) Make include_matches backwards compatible with 7.x config (elastic#30032) [Filebeat] Update handling of elasticsearch server logs (elastic#30018) Remove SSL3 support from libbeat and its documentation. (elastic#30071) Revert "Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY (elastic#28813)" (elastic#30083) [libbeat] Add script processor to all beats (elastic#29752) Add fonts to support more different types of characters for multiple languages (elastic#29861) libbeat/reader: Fix messge conversion to beat.Event (elastic#30057) probot[stale]: ignore issues with the tag flaky-test (elastic#30065) [DOCS] Add redirect for GSuite module (elastic#30034) [Automation] Update elastic stack version to 8.1.0-aa69d697 for testing (elastic#30012) Remove msitools install for windows build, using the latest docker image with msitools preinstalled (elastic#30040) filebeat/generator/fields: fix dropped error (elastic#29943) Include the error message with auditd module events (elastic#30009) [Metricbeat] gcp: add firestore metricset (elastic#29918) probot: update stale dates (elastic#29997) Metricbeat enterprise search module: add xpack.enabled support (elastic#29871) x-pack/packetbeat: install Npcap at start-up when required (elastic#29112) [Filebeat] Fix panic in decode_cef when recovering from invalid data (elastic#30038) Correctly fixe how selected packages are defined (elastic#30039) ...
What does this PR do?
Rename
tar.gz
artifacts witharm64
toaarch64
Why is it important?
Normalise the package naming to match with the same done in Kibana and Elasticsearch.
Issue
Closes #28738
Test
Let's build the tar.gz packages for filebeat in arm64:
then
GCP
For instance, this PR has been verified in the CI and artifacts have been uploaded to the Google Storage bucket:
And the list of files:
While currently for
8.0.0
is the below: