Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): disable E2E tests in Beats #28715

Merged
merged 2 commits into from
Nov 2, 2021
Merged

chore(ci): disable E2E tests in Beats #28715

merged 2 commits into from
Nov 2, 2021

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Oct 29, 2021 •
edited by v1v
Loading

What does this PR do?

This PR comments out the execution of the E2E tests for Fleet at the CI pipelines level. For that we are logging a message instead of the exeuction.

Why is it important?

After recent changes in Kibana, Package Registry and Elastic Package, we are forced to disable the E2E tests as they are always going to fail because the stack is not going to start, causing the test scenarios to drastically fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • @v1v do you see any other place to exclude the E2E tests?

Related issues

I will be adding links to this list once I capture all parts in place (Kibana, package registry, elastic-package, E2E tests...)

@mdelapenya
chore(ci): disable E2E tests in Beats
2d9364d 
At least until latest breaking changes in Kibana affecting Package Registry
are resolved
@mdelapenya
chore(ci): disable E2E tests in packaging job too
969b84b
@mdelapenya mdelapenya added Team:Automation Label for the Observability productivity team backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Oct 29, 2021
@mdelapenya mdelapenya requested a review from a team October 29, 2021 08:14
@mdelapenya mdelapenya self-assigned this Oct 29, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 29, 2021 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-30T05:41:29.216+0000

  • Duration: 62 min 19 sec

  • Commit: 969b84b

Test stats 🧪

Test Results
Failed 0
Passed 20683
Skipped 1521
Total 22204

Steps errors 9

Expand to view the steps failures

generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 0 min 30 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 0 min 1 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 0 min 1 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
Archive system tests files
  • Took 0 min 0 sec . View more details here
  • Description: mage packageSystemTests
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 1 min 30 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 0 min 1 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 0 min 1 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
Archive system tests files
  • Took 0 min 0 sec . View more details here
  • Description: mage packageSystemTests
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@mdelapenya mdelapenya requested review from ruflin and andresrc October 29, 2021 09:44
@cachedout cachedout requested a review from jlind23 October 29, 2021 09:48
@mdelapenya
Copy link
Contributor Author

/test

v1v
v1v approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v do you see any other place to exclude the E2E tests?

I don't recall this anywhere else. #28502 was the one that refactored the e2e call with a shared library step.

@mdelapenya
Copy link
Contributor Author

@v1v do you see any other place to exclude the E2E tests?

I don't recall this anywhere else. #28502 was the one that refactored the e2e call with a shared library step.

I think we are good to go then, thanks!

@mdelapenya mdelapenya merged commit a83e883 into elastic:master Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@mdelapenya
chore(ci): disable E2E tests in Beats (#28715)
3790de3 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@mdelapenya
chore(ci): disable E2E tests in Beats (#28715)
7bb29a2 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
@v1v v1v added the backport-v8.0.0 Automated backport with mergify label Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@mdelapenya
chore(ci): disable E2E tests in Beats (#28715)
7f047d1 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mergify @mdelapenya
chore(ci): disable E2E tests in Beats (#28715) (#28757)
5e9a836 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)

Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mergify @mdelapenya
chore(ci): disable E2E tests in Beats (#28715) (#28756)
5b39548 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)

Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mergify @mdelapenya
chore(ci): disable E2E tests in Beats (#28715) (#28755)
9d22817 
* chore(ci): disable E2E tests in Beats

At least until latest breaking changes in Kibana affecting Package Registry
are resolved

* chore(ci): disable E2E tests in packaging job too

(cherry picked from commit a83e883)

Co-authored-by: Manuel de la Peña <[email protected]>
@mdelapenya mdelapenya deleted the disable-e2e-tests branch November 2, 2021 09:51
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Nov 4, 2021
@mdelapenya
Revert "chore(ci): disable E2E tests in Beats (elastic#28715)"
f0fbe0b 
This reverts commit a83e883.
@mdelapenya mdelapenya mentioned this pull request Nov 4, 2021
Merged
6 tasks
mdelapenya added a commit that referenced this pull request Nov 5, 2021
@mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812)
51414d6 
This reverts commit a83e883.
mergify bot pushed a commit that referenced this pull request Nov 5, 2021
@mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812)
d6625bc 
This reverts commit a83e883.

(cherry picked from commit 51414d6)
mergify bot pushed a commit that referenced this pull request Nov 5, 2021
@mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812)
be0b67a 
This reverts commit a83e883.

(cherry picked from commit 51414d6)
mergify bot pushed a commit that referenced this pull request Nov 5, 2021
@mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812)
b96500d 
This reverts commit a83e883.

(cherry picked from commit 51414d6)
mdelapenya added a commit that referenced this pull request Nov 5, 2021
@mergify @mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812) (#28839
054ebde 
)

This reverts commit a83e883.

(cherry picked from commit 51414d6)

Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya added a commit that referenced this pull request Nov 5, 2021
@mergify @mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812) (#28840
c958550 
)

This reverts commit a83e883.

(cherry picked from commit 51414d6)

Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya added a commit that referenced this pull request Nov 5, 2021
@mergify @mdelapenya
Revert "chore(ci): disable E2E tests in Beats (#28715)" (#28812) (#28841
faf1469 
)

This reverts commit a83e883.

(cherry picked from commit 51414d6)

Co-authored-by: Manuel de la Peña <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Nov 8, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
3afea6c 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
061692b 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @mdelapenya
Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elast…
0574023 
…ic#28812) (elastic#28839)

This reverts commit 0af2ad3.

(cherry picked from commit 61e43e5)

Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@v1v v1v v1v approved these changes

@ruflin ruflin Awaiting requested review from ruflin

@andresrc andresrc Awaiting requested review from andresrc

@jlind23 jlind23 Awaiting requested review from jlind23

Assignees

@mdelapenya mdelapenya

Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdelapenya @elasticmachine @v1v @kuisathaverat