Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] gcp: add firestore metricset #29918

Merged
merged 8 commits into from
Jan 27, 2022
Merged

[Metricbeat] gcp: add firestore metricset #29918

merged 8 commits into from
Jan 27, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jan 19, 2022 •
edited
Loading

What does this PR do?

Adds firestore metricset.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@gpop63 gpop63 added the Team:Integrations Label for the Integrations team label Jan 19, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

This pull request does not have a backport label. Could you fix it @gpop63? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 19, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 19, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-27T11:17:43.704+0000

  • Duration: 103 min 30 sec

  • Commit: 52851b6

Test stats 🧪

Test Results
Failed 0
Passed 9756
Skipped 2528
Total 12284

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63 gpop63 marked this pull request as ready for review January 20, 2022 08:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

endorama
endorama approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please backport it to v8.0

@gpop63 gpop63 added backport-v8.0.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 20, 2022
@gpop63 gpop63 force-pushed the gcp-firestore-metricset branch from 5f9e938 to 3f19c92 Compare January 20, 2022 10:46
@endorama
Copy link
Member

I moved the backport from v8.0.0 to v8.1.0, as that is the correct target release.

@endorama endorama added backport-v8.1.0 Automated backport with mergify and removed backport-v8.0.0 Automated backport with mergify labels Jan 26, 2022
@gpop63 gpop63 force-pushed the gcp-firestore-metricset branch from 3f19c92 to 53ef94f Compare January 26, 2022 11:57
@gpop63
Copy link
Contributor Author

gpop63 commented Jan 26, 2022

/test

1 similar comment
@gpop63
Copy link
Contributor Author

gpop63 commented Jan 27, 2022

/test

@gpop63 gpop63 force-pushed the gcp-firestore-metricset branch from aec86c7 to f70ac04 Compare January 27, 2022 11:15
@gpop63 gpop63 force-pushed the gcp-firestore-metricset branch from f70ac04 to 52851b6 Compare January 27, 2022 11:17
@gpop63 gpop63 merged commit dc1e347 into elastic:master Jan 27, 2022
@endorama endorama removed the backport-v8.1.0 Automated backport with mergify label Jan 28, 2022
v1v added a commit to v1v/beats that referenced this pull request Jan 31, 2022
@v1v
Merge remote-tracking branch 'upstream/master' into feature/bump-stac…
0ca8d43 
…k-version-after-8-0-creation

* upstream/master: (69 commits)
  Update stale config following (elastic#30082)
  Make include_matches backwards compatible with 7.x config (elastic#30032)
  [Filebeat] Update handling of elasticsearch server logs (elastic#30018)
  Remove SSL3 support from libbeat and its documentation. (elastic#30071)
  Revert "Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY (elastic#28813)" (elastic#30083)
  [libbeat] Add script processor to all beats (elastic#29752)
  Add fonts to support more different types of characters for multiple languages (elastic#29861)
  libbeat/reader: Fix messge conversion to beat.Event (elastic#30057)
  probot[stale]: ignore issues with the tag flaky-test (elastic#30065)
  [DOCS] Add redirect for GSuite module (elastic#30034)
  [Automation] Update elastic stack version to 8.1.0-aa69d697 for testing (elastic#30012)
  Remove msitools install for windows build, using the latest docker image with msitools preinstalled (elastic#30040)
  filebeat/generator/fields: fix dropped error (elastic#29943)
  Include the error message with auditd module events (elastic#30009)
  [Metricbeat] gcp: add firestore metricset (elastic#29918)
  probot: update stale dates (elastic#29997)
  Metricbeat enterprise search module: add xpack.enabled support (elastic#29871)
  x-pack/packetbeat: install Npcap at start-up when required (elastic#29112)
  [Filebeat] Fix panic in decode_cef when recovering from invalid data (elastic#30038)
  Correctly fixe how selected packages are defined (elastic#30039)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees

@gpop63 gpop63

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Google Cloud: firestore metricset
3 participants
@gpop63 @elasticmachine @endorama