[apm-ci] When asciidoc speedup skip some stages #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2891 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 83 83
Lines 4355 4355
=======================================
Hits 3452 3452
Misses 903 903 |
v1v
requested review from
kuisathaverat,
simitt,
jalvz,
mdelapenya and
ElWPenn
kuisathaverat
approved these changes
Nov 15, 2019
mdelapenya
approved these changes
Nov 15, 2019
v1v
changed the title
jalvz
approved these changes
Nov 18, 2019
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 18, 2019
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Mar 6, 2020
v1v
added a commit
that referenced
this pull request
Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (#2599) * ci(jenkins): build and test stages are now merged. (#2614) * ci(jenkins): rename APM ITs to avoid any misleading (#2629) * ci(jenkins): revert none agent (#2645) * ci(jenkins): reuse top level agent (#2774) * ci(jenkins): update argument (#2904) * [apm-ci] When asciidoc speedup skip some stages (#2891) * ci(jenkins): change log rotation, use cached repo (#2970) * ci(jenkins): use git reference repo (#2971) * feat: grab docker container logs after run tests (#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998) * ci(jenkins): cancel previous running builds (#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (#3032) * ci(jenkins): when regexp comparator (#2644) * fix: trigger on _beats changes (#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (#3371) * ci(jenkins): apm-its-downstream params has changed (#3406) * fix: build inside a Golang Docker container (#2375) * ci: move benchmark stage to run in a tool Docker container (#2391) * add package install test, add labels to script steps (#2268) * [apm-ci] suppress the NativeCommandError in windows builds (#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (#3428) * ci(jenkins): apm-its are not required in the CI Pipeline
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (elastic#2599) * ci(jenkins): build and test stages are now merged. (elastic#2614) * ci(jenkins): rename APM ITs to avoid any misleading (elastic#2629) * ci(jenkins): revert none agent (elastic#2645) * ci(jenkins): reuse top level agent (elastic#2774) * ci(jenkins): update argument (elastic#2904) * [apm-ci] When asciidoc speedup skip some stages (elastic#2891) * ci(jenkins): change log rotation, use cached repo (elastic#2970) * ci(jenkins): use git reference repo (elastic#2971) * feat: grab docker container logs after run tests (elastic#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (elastic#2998) * ci(jenkins): cancel previous running builds (elastic#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (elastic#3032) * ci(jenkins): when regexp comparator (elastic#2644) * fix: trigger on _beats changes (elastic#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (elastic#3371) * ci(jenkins): apm-its-downstream params has changed (elastic#3406) * fix: build inside a Golang Docker container (elastic#2375) * ci: move benchmark stage to run in a tool Docker container (elastic#2391) * add package install test, add labels to script steps (elastic#2268) * [apm-ci] suppress the NativeCommandError in windows builds (elastic#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (elastic#3428) * ci(jenkins): apm-its are not required in the CI Pipeline
v1v
added a commit
that referenced
this pull request
Mar 10, 2020
* ci(jenkins): backport commits from long time ago (#3438) * ci(jenkins): avoid builds in the master worker (#2599) * ci(jenkins): build and test stages are now merged. (#2614) * ci(jenkins): rename APM ITs to avoid any misleading (#2629) * ci(jenkins): revert none agent (#2645) * ci(jenkins): reuse top level agent (#2774) * ci(jenkins): update argument (#2904) * [apm-ci] When asciidoc speedup skip some stages (#2891) * ci(jenkins): change log rotation, use cached repo (#2970) * ci(jenkins): use git reference repo (#2971) * feat: grab docker container logs after run tests (#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998) * ci(jenkins): cancel previous running builds (#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (#3032) * ci(jenkins): when regexp comparator (#2644) * fix: trigger on _beats changes (#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (#3371) * ci(jenkins): apm-its-downstream params has changed (#3406) * fix: build inside a Golang Docker container (#2375) * ci: move benchmark stage to run in a tool Docker container (#2391) * add package install test, add labels to script steps (#2268) * [apm-ci] suppress the NativeCommandError in windows builds (#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (#3428) * ci(jenkins): apm-its are not required in the CI Pipeline * Use python3 * ci(jenkins): remove leftovers from the APM-ITS * fix: build inside a Golang Docker container (#2375) * fix: use fixed dependencies on golang Docker container (#2410) * ci(jenkins): build CI Docker images (#2498) * partial cherry-pick from #3357 Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2888
This will speed up those PRs which are changing any asciidoc files.
Unfortunately, the current design doesn't allow us to detect this before triggering the build in the CI. See JENKINS-36195.
This approach will help to disable the stages as long as the changeset contains only asciidoc files.
Tasks
Test Cases
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-server%2Fapm-server-mbp/detail/PR-2891/13/pipeline
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-server%2Fapm-server-mbp/detail/PR-2891/12/pipeline