Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger on _beats changes #3189

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Jan 15, 2020

What does this PR do?

It fixes some regular expressions to work with the new implementation of isGitRegionMatch step.

Why is it important?

After merging, all PRs with changes in the regexp specified will trigger the release stage.

              "^_beats.*",
              "^apm-server.yml",
              "^apm-server.docker.yml",
              "^magefile.go",
              "^ingest.*",
              "^packaging.*",
              "^tests/packaging.*",
              "^vendor/github.com/elastic/beats.*"

Related issues

closes #3181

@codecov-io
Copy link

Codecov Report

Merging #3189 into master will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
+ Coverage   78.86%   79.32%   +0.45%     
==========================================
  Files         106      101       -5     
  Lines        5589     5282     -307     
==========================================
- Hits         4408     4190     -218     
+ Misses       1181     1092      -89
Impacted Files Coverage Δ
beater/server.go
beater/onboarding.go
beater/http.go
beater/tracing.go
beater/beater.go

@kuisathaverat kuisathaverat changed the title [WIP] test: trigger on _beats changes fix: trigger on _beats changes Jan 17, 2020
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@kuisathaverat kuisathaverat merged commit 4824cbb into elastic:master Jan 20, 2020
v1v pushed a commit to v1v/apm-server that referenced this pull request Mar 6, 2020
v1v added a commit that referenced this pull request Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (#2599)
* ci(jenkins): build and test stages are now merged. (#2614)
* ci(jenkins): rename APM ITs to avoid any misleading (#2629)
* ci(jenkins): revert none agent (#2645)
* ci(jenkins): reuse top level agent (#2774)
* ci(jenkins): update argument (#2904)
* [apm-ci] When asciidoc speedup skip some stages (#2891)
* ci(jenkins): change log rotation, use cached repo (#2970)
* ci(jenkins): use git reference repo (#2971)
* feat: grab docker container logs after run tests (#2948)
* ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998)
* ci(jenkins): cancel previous running builds (#2983)
* feat: enable DIAGNOSTIC_INTERVAL env var (#3032)
* ci(jenkins): when regexp comparator (#2644)
* fix: trigger on _beats changes (#3189)
* ci(jenkins): retry build docker image up to 3 times with some sleep
* Simplify build scripts (#3371)
* ci(jenkins): apm-its-downstream params has changed (#3406)
* fix: build inside a Golang Docker container (#2375)
* ci: move benchmark stage to run in a tool Docker container (#2391)
* add package install test, add labels to script steps (#2268)
* [apm-ci] suppress the NativeCommandError in windows builds (#2890)
* ci(jenkins): fix issues with python3 in branch 6.8 (#3428)
* ci(jenkins): apm-its are not required in the CI Pipeline
v1v added a commit to v1v/apm-server that referenced this pull request Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (elastic#2599)
* ci(jenkins): build and test stages are now merged. (elastic#2614)
* ci(jenkins): rename APM ITs to avoid any misleading (elastic#2629)
* ci(jenkins): revert none agent (elastic#2645)
* ci(jenkins): reuse top level agent (elastic#2774)
* ci(jenkins): update argument (elastic#2904)
* [apm-ci] When asciidoc speedup skip some stages (elastic#2891)
* ci(jenkins): change log rotation, use cached repo (elastic#2970)
* ci(jenkins): use git reference repo (elastic#2971)
* feat: grab docker container logs after run tests (elastic#2948)
* ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (elastic#2998)
* ci(jenkins): cancel previous running builds (elastic#2983)
* feat: enable DIAGNOSTIC_INTERVAL env var (elastic#3032)
* ci(jenkins): when regexp comparator (elastic#2644)
* fix: trigger on _beats changes (elastic#3189)
* ci(jenkins): retry build docker image up to 3 times with some sleep
* Simplify build scripts (elastic#3371)
* ci(jenkins): apm-its-downstream params has changed (elastic#3406)
* fix: build inside a Golang Docker container (elastic#2375)
* ci: move benchmark stage to run in a tool Docker container (elastic#2391)
* add package install test, add labels to script steps (elastic#2268)
* [apm-ci] suppress the NativeCommandError in windows builds (elastic#2890)
* ci(jenkins): fix issues with python3 in branch 6.8 (elastic#3428)
* ci(jenkins): apm-its are not required in the CI Pipeline
v1v added a commit that referenced this pull request Mar 10, 2020
* ci(jenkins): backport commits from long time ago (#3438)
* ci(jenkins): avoid builds in the master worker (#2599)
* ci(jenkins): build and test stages are now merged. (#2614)
* ci(jenkins): rename APM ITs to avoid any misleading (#2629)
* ci(jenkins): revert none agent (#2645)
* ci(jenkins): reuse top level agent (#2774)
* ci(jenkins): update argument (#2904)
* [apm-ci] When asciidoc speedup skip some stages (#2891)
* ci(jenkins): change log rotation, use cached repo (#2970)
* ci(jenkins): use git reference repo (#2971)
* feat: grab docker container logs after run tests (#2948)
* ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998)
* ci(jenkins): cancel previous running builds (#2983)
* feat: enable DIAGNOSTIC_INTERVAL env var (#3032)
* ci(jenkins): when regexp comparator (#2644)
* fix: trigger on _beats changes (#3189)
* ci(jenkins): retry build docker image up to 3 times with some sleep
* Simplify build scripts (#3371)
* ci(jenkins): apm-its-downstream params has changed (#3406)
* fix: build inside a Golang Docker container (#2375)
* ci: move benchmark stage to run in a tool Docker container (#2391)
* add package install test, add labels to script steps (#2268)
* [apm-ci] suppress the NativeCommandError in windows builds (#2890)
* ci(jenkins): fix issues with python3 in branch 6.8 (#3428)
* ci(jenkins): apm-its are not required in the CI Pipeline
* Use python3
* ci(jenkins): remove leftovers from the APM-ITS
* fix: build inside a Golang Docker container (#2375)
* fix: use fixed dependencies on golang Docker container (#2410)
* ci(jenkins): build CI Docker images (#2498)
* partial cherry-pick from #3357

Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run packaging tests on relevant prs
4 participants