add package install test, add labels to script steps #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, I'll leave the go not in path issue to you |
kuisathaverat
force-pushed
the
package-install-tests
branch
5 times, most recently
from
d3362fd to
dde9221
Compare
|
I am checking the APM-Server builds and the build step on linux it is silence failing |
kuisathaverat
force-pushed
the
package-install-tests
branch
19 times, most recently
from
da180c0 to
413bd37
Compare
Co-Authored-By: Gil Raphaelli <[email protected]>
kuisathaverat
force-pushed
the
package-install-tests
branch
from
6cd17a3 to
48fc975
Compare
|
@kuisathaverat can you please close this PR then and link it in the smaller ones that you are going to open, or reopen once a review is desired again. |
|
@simitt it is already split in several PRs, most of them merged. This PR is rebased on master branch now so there is only one unrelated change in it (#2391), if we review and merge it we can rebase this PR again for a final review.
|
|
Also out of this came:
|
|
@graphaelli I leave this review up to you, as I think you've been more involved in the mage changes than I was. |
graphaelli
reviewed
Jul 11, 2019
tests/packaging/package_test.go
Outdated
| @@ -34,7 +34,8 @@ var ( | |||
| ) | |||
|
|
|||
| func TestDeb(t *testing.T) { | |||
| debs := getFiles(t, regexp.MustCompile(`\.deb$`)) | |||
| // only test x86 packages, excluding arm | |||
| debs := getFiles(t, regexp.MustCompile(`(i386|i686|amd64|x86)*.\.deb$`)) | |||
There was a problem hiding this comment.
Let's revert this as the jenkins build doesn't need it any more
graphaelli
reviewed
Jul 11, 2019
graphaelli
approved these changes
Jul 16, 2019
v1v
pushed a commit
to v1v/apm-server
that referenced
this pull request
Mar 6, 2020
* add package install test, add labels to script steps
v1v
added a commit
that referenced
this pull request
Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (#2599) * ci(jenkins): build and test stages are now merged. (#2614) * ci(jenkins): rename APM ITs to avoid any misleading (#2629) * ci(jenkins): revert none agent (#2645) * ci(jenkins): reuse top level agent (#2774) * ci(jenkins): update argument (#2904) * [apm-ci] When asciidoc speedup skip some stages (#2891) * ci(jenkins): change log rotation, use cached repo (#2970) * ci(jenkins): use git reference repo (#2971) * feat: grab docker container logs after run tests (#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998) * ci(jenkins): cancel previous running builds (#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (#3032) * ci(jenkins): when regexp comparator (#2644) * fix: trigger on _beats changes (#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (#3371) * ci(jenkins): apm-its-downstream params has changed (#3406) * fix: build inside a Golang Docker container (#2375) * ci: move benchmark stage to run in a tool Docker container (#2391) * add package install test, add labels to script steps (#2268) * [apm-ci] suppress the NativeCommandError in windows builds (#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (#3428) * ci(jenkins): apm-its are not required in the CI Pipeline
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Mar 9, 2020
* ci(jenkins): avoid builds in the master worker (elastic#2599) * ci(jenkins): build and test stages are now merged. (elastic#2614) * ci(jenkins): rename APM ITs to avoid any misleading (elastic#2629) * ci(jenkins): revert none agent (elastic#2645) * ci(jenkins): reuse top level agent (elastic#2774) * ci(jenkins): update argument (elastic#2904) * [apm-ci] When asciidoc speedup skip some stages (elastic#2891) * ci(jenkins): change log rotation, use cached repo (elastic#2970) * ci(jenkins): use git reference repo (elastic#2971) * feat: grab docker container logs after run tests (elastic#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (elastic#2998) * ci(jenkins): cancel previous running builds (elastic#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (elastic#3032) * ci(jenkins): when regexp comparator (elastic#2644) * fix: trigger on _beats changes (elastic#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (elastic#3371) * ci(jenkins): apm-its-downstream params has changed (elastic#3406) * fix: build inside a Golang Docker container (elastic#2375) * ci: move benchmark stage to run in a tool Docker container (elastic#2391) * add package install test, add labels to script steps (elastic#2268) * [apm-ci] suppress the NativeCommandError in windows builds (elastic#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (elastic#3428) * ci(jenkins): apm-its are not required in the CI Pipeline
v1v
added a commit
that referenced
this pull request
Mar 10, 2020
* ci(jenkins): backport commits from long time ago (#3438) * ci(jenkins): avoid builds in the master worker (#2599) * ci(jenkins): build and test stages are now merged. (#2614) * ci(jenkins): rename APM ITs to avoid any misleading (#2629) * ci(jenkins): revert none agent (#2645) * ci(jenkins): reuse top level agent (#2774) * ci(jenkins): update argument (#2904) * [apm-ci] When asciidoc speedup skip some stages (#2891) * ci(jenkins): change log rotation, use cached repo (#2970) * ci(jenkins): use git reference repo (#2971) * feat: grab docker container logs after run tests (#2948) * ci(jenkins): shallow cloning doesn't work with isGitRegionMatch (#2998) * ci(jenkins): cancel previous running builds (#2983) * feat: enable DIAGNOSTIC_INTERVAL env var (#3032) * ci(jenkins): when regexp comparator (#2644) * fix: trigger on _beats changes (#3189) * ci(jenkins): retry build docker image up to 3 times with some sleep * Simplify build scripts (#3371) * ci(jenkins): apm-its-downstream params has changed (#3406) * fix: build inside a Golang Docker container (#2375) * ci: move benchmark stage to run in a tool Docker container (#2391) * add package install test, add labels to script steps (#2268) * [apm-ci] suppress the NativeCommandError in windows builds (#2890) * ci(jenkins): fix issues with python3 in branch 6.8 (#3428) * ci(jenkins): apm-its are not required in the CI Pipeline * Use python3 * ci(jenkins): remove leftovers from the APM-ITS * fix: build inside a Golang Docker container (#2375) * fix: use fixed dependencies on golang Docker container (#2410) * ci(jenkins): build CI Docker images (#2498) * partial cherry-pick from #3357 Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are moved to other PRs
add labels to script steps - ci: add labels to script commands #2378
add Tool Docker container with the Golang version used and tools needed - fix: build inside a Golang Docker container #2375
use plain Go or mage commands inside the Tool Docker container - fix: build inside a Golang Docker container #2375
fix Release build trigger, it was trigger always not only with beats updates. - fix: release stage should not be triggered always #2379
move benchmark stage to run in the tool Docker container - ci: move benchmark stage to run in a tool Docker container #2391