Plan and Pop inbox fix

[rachana-egov]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced ConfirmationPopUp with updated button prominence for improved user interaction.
  • SearchJurisdiction now allows initialization with predefined values and submits additional context.
  • PlanInbox, PopInbox, and FacilityPopup components now manage default selections for hierarchy and boundaries, improving search and filter functionalities.

• Bug Fixes

  • Improved error handling in the fetchStatusCount function with better toast notifications.

• Chores

  • Streamlined loading state management across components for a more responsive UI.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes involve modifications to several components within the micro-ui framework. The ConfirmationPopUp component's button configurations have been altered, changing their visual prominence. The SearchJurisdiction, PlanInbox, and PopInbox components have been enhanced with new props and state management features, allowing for improved initialization and submission of values. These updates also include adjustments to API interactions and error handling, ensuring a more robust user experience.

Changes

File	Change Summary
.../ConfirmationPopUp.js	Updated button configurations: "close" button changed from secondary to primary, "submit" button changed from primary to secondary.
.../SearchJurisdiction.js	Added defaultHierarchy and defaultBoundaries props; updated initial state management; introduced useRef for initial load tracking; modified onSubmit to include selectedHierarchy.
.../PlanInbox.js	Introduced state variables for totalStatusCount, defaultHierarchy, and defaultBoundaries; implemented API mutation for fetching status counts; updated onSearch and onClear functions to handle new parameters and states.
.../PopInbox.js	Added defaultHierarchy and defaultBoundaries state variables; updated onSearch and onClear functions; modified useSearchPlanConfig hook to always fetch data; improved error handling in fetchStatusCount.
.../FacilityPopup.js	Introduced defaultHierarchy and defaultBoundaries state variables; added onSearch and onClear functions; updated props for SearchJurisdiction to include new state variables.

Possibly related PRs

• Update SetupMaster.js #1422: Modifications in SetupMaster.js involve changing button configurations similar to those in ConfirmationPopUp.js.
• Added confirmation pop up to finalise actions #1832: Introduction of the ConfirmationPopUp component directly relates to the modifications in this PR.
• Plan Inbox patch fix #1847: Enhancements in PlanInbox.js include user interaction improvements and button states relevant to ConfirmationPopUp.js.
• Po finding fixes2 #1845: Updates in PlanInbox.js regarding handling of selected rows and display of data improve user experience, aligning with the goals of the main PR's updates.
• qquickfix #1878: Modifications in PlanInbox.js refine logic for managing selected rows and user interactions, related to overall improvements in user feedback and action handling.

Suggested reviewers

• nipunarora-eGov

🐰 "In the UI where buttons play,
A change in colors brightens the day.
With new props and states in view,
Our components now have much more to do!
Hopping along with joy and cheer,
We celebrate these changes, oh so dear!" 🐇

Warning

Rate limit exceeded

@rachana-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e42dcb4 and cb1955e.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between e42dcb4 and cb1955e.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (14 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🔇 Additional comments (5)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (5)

Line range hint 227-239: Search handler updates state appropriately

The onSearch function correctly handles the case when boundaries are selected and updates the relevant state variables (activeLink, defaultSelectedHierarchy, and defaultBoundaries) accordingly.

---

305-306: Clear function resets default selections

The onClear function properly resets defaultBoundaries and defaultSelectedHierarchy, ensuring that the search filters are cleared and the census jurisdiction is reset.

---

348-356: Status count reordering is correctly implemented

The code effectively filters out the PENDING_FOR_APPROVAL status and reorders the StatusCount to prioritize PENDING_FOR_VALIDATION. This ensures that the statuses are displayed in the desired order.

---

733-734: Passing default selections to SearchJurisdiction

The defaultHierarchy and defaultBoundaries props are accurately passed to the SearchJurisdiction component, which will initialize the search filters with these default values.

---

842-842: Refreshing status count after workflow action

Calling fetchStatusCount() after a successful workflow action ensures that the status counts are updated to reflect any changes resulting from the action.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (1)

Line range hint 28-43: Consider extracting boundary filtering logic into a separate utility function.

The boundary filtering logic could be moved to a utility function to improve maintainability and reusability. This would also make the useEffect hook cleaner and more focused.

+const filterAndGroupBoundaries = (boundaries, jurisdiction, selectedHierarchy) => {
+  const userBoundaries = Digit.Utils.microplanv1.filterBoundariesByJurisdiction(
+    boundaries,
+    jurisdiction.boundaryCodes
+  );
+  const filteredBoundaries = userBoundaries.filter(
+    (row) => row.type === selectedHierarchy.boundaryType
+  );
+  return Digit.Utils.microplanv1.groupByParent(filteredBoundaries);
+};

 useEffect(() => {
   if (!selectedHierarchy) {
     setBoundaryOptions([]);
     return;
   }
-  const userBoundaries = Digit.Utils.microplanv1.filterBoundariesByJurisdiction(boundaries, jurisdiction.boundaryCodes);
-  const filteredBoundaries = userBoundaries.filter((row) => row.type === selectedHierarchy.boundaryType);
-  const filteredBoundariesGroupedByParent = Digit.Utils.microplanv1.groupByParent(filteredBoundaries);
+  const filteredBoundariesGroupedByParent = filterAndGroupBoundaries(
+    boundaries,
+    jurisdiction,
+    selectedHierarchy
+  );
   setBoundaryOptions(filteredBoundariesGroupedByParent);

   if (!isInitialLoad.current) {
     setSelectedBoundaries([]);
   } else {
     isInitialLoad.current = false;
   }
 }, [selectedHierarchy]);

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 878-897: Simplify complex conditional rendering expressions

The conditional expressions for rendering the ActionBar components are complex and may reduce readability. Consider extracting these conditions into well-named variables to enhance clarity.

Apply this diff to simplify the conditional rendering:

+ const shouldShowFinalizeActionBar = isRootApprover && isStatusConditionMet(totalStatusCount);
+ const shouldShowBackButtonActionBar = (!isRootApprover && isStatusConditionMet(totalStatusCount) && planObject?.status === "RESOURCE_ESTIMATION_IN_PROGRESS") || disabledAction;

...

{shouldShowFinalizeActionBar && (
  <ActionBar
    actionFields={[
      <Button
        icon="CheckCircle"
        label={t(`HCM_MICROPLAN_FINALIZE_MICROPLAN`)}
        onClick={handleActionBarClick}
        type="button"
        variation="primary"
      />,
    ]}
    className=""
    maxActionFieldsAllowed={5}
    setactionFieldsToRight
    sortActionFields
    style={{}}
  />
)}

{shouldShowBackButtonActionBar && (
  <ActionBar
    actionFields={[
      <Button
        label={t(`HCM_MICROPLAN_PLAN_INBOX_BACK_BUTTON`)}
        onClick={() => {
          history.push(`/${window.contextPath}/employee`);
        }}
        type="button"
        variation="primary"
      />,
    ]}
    className=""
    maxActionFieldsAllowed={5}
    setactionFieldsToRight
    sortActionFields
    style={{}}
  />
)}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 0343381 and bacfc33.

📒 Files selected for processing (4)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (4 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (13 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

📓 Learnings (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1832
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:592-594
Timestamp: 2024-11-14T12:48:23.024Z
Learning: In `PopInbox.js`, when integrating the `ConfirmationPopUp` component, error handling for API failures is managed internally within the component, so explicitly passing an `onError` prop is not necessary.

🔇 Additional comments (15)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (1)

Line range hint 1-85: LGTM! Well-structured component with proper error handling

The component demonstrates good practices:

• Proper loading state management with isSubmitting
• Error handling with Toast notifications
• API mutation handling with success/error callbacks
• Button disable states during submission

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js (2)

21-26: LGTM! Clean state management implementation.

The state initialization with default props and the use of useRef for tracking the initial load state is well implemented and follows React best practices.

---

112-112: Verify that all callers handle the updated onSubmit signature.

The onSubmit function now includes selectedHierarchy as a second parameter. Ensure that all parent components using this component handle both parameters correctly.

✅ Verification successful

All callers correctly handle the updated onSubmit signature

The verification shows that all three components using SearchJurisdiction (PlanInbox.js, PopInbox.js, and FacilityPopup.js) properly handle both parameters:

• PlanInbox.js and PopInbox.js both define onSearch(selectedBoundaries, selectedHierarchy) with identical parameter handling
• FacilityPopup.js uses censusSearch which only needs the boundaries parameter, which is a valid subset usage

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for components using SearchJurisdiction to verify onSubmit usage
rg -l "SearchJurisdiction" | xargs rg -A 5 "onSubmit={" 

Length of output: 139

---

Script:

#!/bin/bash
# Search for components using SearchJurisdiction
rg -l "SearchJurisdiction"

Length of output: 422

---

Script:

#!/bin/bash
# Search for usage of SearchJurisdiction component with context
rg -B 3 -A 10 "<SearchJurisdiction"

Length of output: 5510

---

Script:

#!/bin/bash
# Search for onSubmit prop in files containing SearchJurisdiction
ast-grep --pattern 'onSubmit={$_}'

Length of output: 36

---

Script:

#!/bin/bash
# Search for onSearch function definition in PlanInbox.js
rg -B 5 -A 15 "const onSearch" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js

# Search for onSearch function definition in PopInbox.js
rg -B 5 -A 15 "const onSearch" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js

# Search for censusSearch function definition in FacilityPopup.js
rg -B 5 -A 15 "const censusSearch" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js

Length of output: 3163

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (5)

45-46: LGTM! State management implementation looks good.

The new state variables are well-named and properly initialized with appropriate default values.

---

Line range hint 158-169: LGTM! Search functionality is well implemented.

The search implementation includes proper validation for empty boundaries and appropriate state updates. The warning toast for empty boundaries provides good user feedback.

---

245-246: LGTM! Clear functionality properly resets states.

The clear implementation correctly resets both boundary and hierarchy states to their initial values.

---

528-528: LGTM! Loading state handling is comprehensive.

The loading check properly includes all relevant async operations, ensuring a consistent loading experience.

---

561-566: Verify prop handling in SearchJurisdiction component.

New props have been added to SearchJurisdiction. Ensure that the SearchJurisdiction component properly handles these props, especially for initialization and updates.

✅ Verification successful

Props are properly handled in SearchJurisdiction component

The SearchJurisdiction component correctly implements and handles both defaultHierarchy and defaultBoundaries props:

• Props are properly declared with default values (null and [] respectively)
• Values are correctly used to initialize the component's state using useState
• Component includes proper state management and update logic for both hierarchy and boundaries
• Initial load is tracked using useRef to prevent unwanted boundary resets

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check SearchJurisdiction component implementation
ast-grep --pattern 'const SearchJurisdiction = ({ defaultHierarchy, defaultBoundaries, $$$_ }) => {
  $$$
}'

Length of output: 110

---

Script:

#!/bin/bash
# Let's try to find the SearchJurisdiction component file first
fd SearchJurisdiction

# Then let's look for any file containing SearchJurisdiction component definition
rg -l "SearchJurisdiction.*=.*{" 

# As a backup, search for files containing SearchJurisdiction
rg -l "SearchJurisdiction"

Length of output: 696

---

Script:

#!/bin/bash
# Let's examine the SearchJurisdiction component implementation
cat health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js

# Also check for any usages of defaultHierarchy and defaultBoundaries props
rg "defaultHierarchy|defaultBoundaries" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/SearchJurisdiction.js

Length of output: 5203

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (7)

160-160: LGTM!

The addition of isFetching to manage the loading state is appropriate.

---

Line range hint 227-239: Update 'onSearch' function to handle default selections

The changes to the onSearch function correctly handle the default hierarchy and boundaries selections.

---

305-306: LGTM!

Resetting defaultBoundaries and defaultSelectedHierarchy in the onClear function is appropriate.

---

680-680: Include 'mutation.isLoading' in loading state check

Adding mutation.isLoading to the loading condition ensures that the loader is displayed during the mutation process.

---

729-730: Passing default values to 'SearchJurisdiction' component

Providing defaultHierarchy and defaultBoundaries as props enhances the functionality of the SearchJurisdiction component.

---

838-838: Refresh status count after workflow action success

Calling fetchStatusCount() after a successful workflow action ensures that the status count is updated accordingly.

---

848-848: Display loader during data fetching

Using isFetching to display the loader provides a better user experience while data is being fetched.

[coderabbitai]

Actionable comments posted: 4

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 227-239: Remove unnecessary null checks for planWithCensus?.StatusCount[selectedFilter]

Based on previous learnings, planWithCensus?.StatusCount[selectedFilter] is always defined in this context. Remove redundant null checks to simplify the code.

Apply this diff to remove unnecessary null checks:

- if (selectedFilter === null || selectedFilter === undefined || selectedFilter === "" || !activeFilterKeys.includes(selectedFilter)) {
+ if (!selectedFilter || !activeFilterKeys.includes(selectedFilter)) {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between bacfc33 and 6a31fcb.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (13 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

📓 Learnings (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (2)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1832
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:592-594
Timestamp: 2024-11-14T12:48:23.024Z
Learning: In `PopInbox.js`, when integrating the `ConfirmationPopUp` component, error handling for API failures is managed internally within the component, so explicitly passing an `onError` prop is not necessary.

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1837
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:559-561
Timestamp: 2024-11-15T10:15:57.370Z
Learning: In `PopInbox.js`, error handling for the `onError` callback in `WorkflowCommentPopUp` is handled within the component, so explicit error handling in the parent component is unnecessary.

🔇 Additional comments (12)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (6)

45-46: LGTM! State management for hierarchy and boundaries.

The new state variables are properly initialized and follow consistent naming conventions.

---

Line range hint 158-169: LGTM! Enhanced search functionality with proper validation.

The search function correctly validates the boundary selection and updates the hierarchy and boundary states appropriately.

---

245-246: LGTM! Proper state reset in clear functionality.

The clear function correctly resets the hierarchy and boundary states to their initial values.

---

528-528: LGTM! Comprehensive loading state handling.

The loading check properly includes all asynchronous operations, including mutations.

---

561-566: LGTM! Proper prop passing to SearchJurisdiction.

The defaultHierarchy and defaultBoundaries props are correctly passed to the SearchJurisdiction component.

---

69-69: 🧹 Nitpick (assertive)

Consider conditional fetching of plan configuration.

Setting enabled: true unconditionally might lead to unnecessary API calls. Consider keeping it conditional based on when the plan configuration is actually needed.

-      enabled: true,
+      enabled: microplanId ? true : false,

Likely invalid or redundant comment.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (6)

305-306: Initialize state variables consistently

The state setters setDefaultBoundaries and setDefaultSelectedHierarchy are being reset in onClear. Ensure consistent initialization by setting setDefaultSelectedHierarchy to null, similar to how setDefaultBoundaries is set to an empty array.

---

838-838: Redundant call to fetchStatusCount after refetch

After calling refetchPlanWithCensus(), calling fetchStatusCount() may be redundant if the data fetched by refetchPlanWithCensus() includes updated status counts. Verify if both calls are necessary.

---

89-116: Simplify fetchStatusCount by handling success directly

When using await mutation.mutateAsync(), the onSuccess and onError callbacks within the options may not be effective. Since you're awaiting the promise, handle the success and error directly in the try and catch blocks.

---

739-739: Extract complex inline styles into a variable

The inline style for marginBottom is complex and affects readability. Extract the condition into a separate variable for clarity.

---

729-730: Ensure SearchJurisdiction accepts new props

The defaultHierarchy and defaultBoundaries props are being passed to SearchJurisdiction. Verify that the SearchJurisdiction component is updated to accept and handle these new props appropriately.

Run the following script to check the SearchJurisdiction component's prop definitions:

✅ Verification successful

SearchJurisdiction component properly accepts and handles the new props

The component definition in SearchJurisdiction.js shows that both defaultHierarchy and defaultBoundaries props are properly declared and handled:

• Props are defined in the component signature (lines 7-10)
• Default values are set appropriately:
  • defaultHierarchy = null
  • defaultBoundaries = []
• Props are used correctly in the component:
  • Line 21: useState(defaultBoundaries)
  • Line 22: useState(defaultHierarchy)

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `SearchJurisdiction` accepts `defaultHierarchy` and `defaultBoundaries` props.

# Search for the prop definitions in `SearchJurisdiction` component.
rg --type js 'SearchJurisdiction.*props' -A 10

Length of output: 48

---

Script:

#!/bin/bash
# Let's try different approaches to locate the SearchJurisdiction component and its props

# First, find all files that might contain SearchJurisdiction
fd -e js -e jsx SearchJurisdiction

# Then search for SearchJurisdiction component definition using ast-grep
ast-grep --pattern 'const SearchJurisdiction = $_'

# Also try to find any usage of SearchJurisdiction as a component
ast-grep --pattern '<SearchJurisdiction $$$>'

# Backup search using ripgrep for any mention of SearchJurisdiction
rg "SearchJurisdiction"

Length of output: 17826

---

Line range hint 227-239: Verify that all usages of onSearch are updated

The onSearch function now accepts an additional parameter selectedHierarchy. Ensure that all components invoking onSearch are updated to pass the new parameter to prevent potential runtime errors.

Run the following script to verify all calls to onSearch:

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 6a31fcb and e42dcb4.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1)

34-35: LGTM: State variables properly initialized

The new state variables follow React conventions and have appropriate initial values.