Action bar fixes, session fixes

[nabeelmd-eGov]

• added serving facility
• form composer action bar fix
• plan inbox assignee fix
• formula and assumption refresh issue
• action bar hidden fixes, session fixes

Choose the appropriate template for your PR:

• Feature PR
• Bugfix PR
• Release PR

Summary by CodeRabbit

• New Features

  • Enhanced user input validation in the FormulaConfigWrapper and HypothesisWrapper components, including checks for mandatory fields and NaN values.
  • Improved session management by clearing specific session storage items when navigating between pages.

• Bug Fixes

  • Adjusted control flow to prevent users from skipping required fields in the HypothesisWrapper component.

• Chores

  • Refined logic for displaying next action labels in the SetupMicroplan component based on current steps.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces several modifications across multiple components, primarily focusing on enhancing state management and user input validation. Key changes include the removal of cleanup functions in useEffect hooks for FormulaConfigWrapper and HypothesisWrapper, which may affect state retention upon unmounting. New validation logic has been added to ensure mandatory fields are filled and to check for NaN values, triggering toast notifications for invalid inputs. Additionally, session storage management has been improved in SetupMicroplan and index.js, ensuring that specific data is cleared appropriately during navigation.

Changes

File	Change Summary
health/micro-ui/.../FormulaConfigWrapper.js	Removed cleanup function from useEffect; updated handleNext for validation and resource update.
health/micro-ui/.../HypothesisWrapper.js	Removed cleanup from useEffect; added validation for NaN and empty fields; updated URL parameters.
health/micro-ui/.../SetupMicroplan.js	Added session storage cleanup for HYPOTHESIS_DATA and FORMULA_DATA; refined next action label logic.
health/micro-ui/.../employee/index.js	Enhanced session management by adding deletions of HYPOTHESIS_DATA and FORMULA_DATA in useEffect.

Possibly related PRs

• ESTIMATION & FORMULA FIXES #1804: The changes in FormulaConfigWrapper.js regarding validation checks for mandatory fields and session management are closely related to the main PR's focus on enhancing error handling and user input validation.
• formula and assumption refresh issue #1864: The updates in FormulaConfigWrapper.js and HypothesisWrapper.js regarding session storage and validation checks for assumptions align with the main PR's modifications to improve state management and validation logic.
• Action bar fixes, session fixes #1867: The modifications in FormulaConfigWrapper.js that involve validation checks and session management are directly related to the main PR's focus on refining control flow and enhancing error handling within the component.

Suggested reviewers

• nipunarora-eGov

🐰 In the garden where bunnies play,
New changes hop in, brightening the day.
With formulas and hypotheses in line,
Validations now sparkle and shine.
Session data clears, making room for more,
A joyful leap in code, we all adore! 🌼✨

Warning

Rate limit exceeded

@nabeelmd-eGov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a3c837b and 6407593.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 4a4e762 and a3c837b.

📒 Files selected for processing (4)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (0 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1 hunks)

💤 Files with no reviewable changes (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1)

Pattern **/*.js: check

🪛 Biome

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js

[error] 175-175: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

🔇 Additional comments (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1)

66-78: Verify the impact of session cleanup on user experience.

The code clears multiple session storage items when navigating away from the setup page or when on the response page. This could affect user experience if they need to preserve this data for specific navigation patterns.

Let's verify the navigation paths where this session data is used:

✅ Verification successful

Let me gather more information about the navigation flow and where this data is being set to understand the cleanup impact better.

---

Let me search for more specific patterns to understand where this data is being set and used in the workflow.

---

Based on the analysis of the code, I can now generate a final response about the session cleanup impact.

Session cleanup is correctly implemented and does not impact user experience negatively

The session storage cleanup is intentionally designed to work this way:

• Data is cleared when navigating away from setup-microplan page to prevent stale data persistence
• The cleanup on the response page is necessary as it marks the end of a workflow
• The components (HypothesisWrapper and FormulaConfigWrapper) properly handle their own session data within their lifecycle
• The cleanup prevents old data from interfering with new microplan setups

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for usage of these session storage keys in the codebase
echo "Searching for session storage key usage..."
rg -A 3 "SessionStorage\.(get|set)\(\"(HYPOTHESIS_DATA|FORMULA_DATA|MICROPLAN_DATA)\""

# Search for components that might be affected by this cleanup
echo "Searching for related components..."
rg -l "FormulaConfigWrapper|HypothesisWrapper"

Length of output: 8608

---

Script:

#!/bin/bash
# Search for routes and navigation paths
echo "Searching for route definitions and navigation..."
rg -A 3 "path.*microplan.*setup-microplan|path.*microplan.*response"

# Search for where these session storage items are being set
echo "Searching for where session data is being set..."
rg "SessionStorage\.set\(\"(HYPOTHESIS_DATA|FORMULA_DATA|MICROPLAN_DATA)\""

# Look for any cleanup or navigation hooks
echo "Searching for cleanup or navigation related code..."
rg "useEffect.*cleanup|onSubmit.*microplan"

Length of output: 2433

---

Script:

#!/bin/bash
# Search for any form submissions or state updates that might set session storage
echo "Searching for form submissions and state updates..."
rg -A 5 "onFormSubmit|onSubmit|setState.*MICROPLAN|setState.*HYPOTHESIS|setState.*FORMULA"

# Look for navigation or routing logic
echo "Searching for navigation patterns..."
rg -A 3 "navigate\(.*microplan|history\.push.*microplan"

# Search for components that might be setting this data
echo "Searching in specific component files..."
rg "Digit\.SessionStorage" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js

Length of output: 104067

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

313-314: LGTM! Verify session cleanup impact.

The addition of session storage cleanup for hypothesis and formula data aligns with the PR's objective of fixing session-related issues.

Let's verify the session storage usage across the codebase:

✅ Verification successful

Session storage cleanup is consistent with codebase usage

The session storage cleanup for HYPOTHESIS_DATA and FORMULA_DATA is properly implemented and aligns with their usage across the codebase:

• Both keys are used in dedicated wrapper components (HypothesisWrapper.js and FormulaConfigWrapper.js) with proper hooks
• Similar cleanup is already implemented in index.js for different navigation scenarios
• The cleanup in SetupMicroplan.js follows the same pattern when navigating back to employee page

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any other components that might be affected by the session storage cleanup

# Check for HYPOTHESIS_DATA usage
echo "Checking HYPOTHESIS_DATA usage:"
rg "HYPOTHESIS_DATA" -A 3

# Check for FORMULA_DATA usage
echo "Checking FORMULA_DATA usage:"
rg "FORMULA_DATA" -A 3

Length of output: 8355

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

175-175: ⚠️ Potential issue

Use Number.isNaN(Number(value)) instead of isNaN(value)

The global isNaN function performs type coercion, which can lead to unexpected results, especially with string inputs. By converting the value to a number and using Number.isNaN, you ensure accurate detection of NaN without unintended type coercion.

Apply this diff to fix the issue:

-   return !value || isNaN(value); // Check if any value is NAN
+   return Number.isNaN(Number(value)); // Check if the value is NaN

⛔ Skipped due to learnings

Learnt from: siddhant-nawale-egov
PR: egovernments/DIGIT-Frontend#938
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreviewHelperCompoenents.js:220-220
Timestamp: 2024-11-10T20:01:49.000Z
Learning: User siddhant-nawale-egov prefers using `isNaN` over `Number.isNaN` for scenarios where type coercion is desired in JavaScript.

🧰 Tools

🪛 Biome

[error] 175-175: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

Resolved all the points still not letting merge