Internal demo fixes

[rachana-egov]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced new configurations for enhanced search and user management, including custom validation for mobile numbers.
  • Added new configurations for facility mapping and microplan search.
  • Added a new action type for workflow management, "ROOT_APPROVE," enhancing user role management.
  • Introduced a new column in the inbox table for displaying assignee information.

• Improvements

  • Enhanced error handling for user input validations.
  • Updated timeline data handling to ensure accurate display of assignee information.
  • Improved button labels for security and accessibility based on available details.
  • Streamlined component logic by removing unnecessary dropdown handling.
  • Removed handling of the village transport mode field from data processing.

• Bug Fixes

  • Temporarily disabled the "VIEW_MICROPLAN_ESTIMATIONS" card in the activity selection UI.

• Style

  • Adjusted button styles for improved layout consistency in the UI.

These updates aim to enhance user experience through improved functionality and interface consistency.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces significant enhancements to the UICustomizations object across various files. Key updates include the addition of new configurations, enhancement of existing methods, and improvements in error handling and validation processes. Modifications to the timelinePopUpWrapper component ensure accurate data retrieval from the API. Additionally, the ChooseActivity component temporarily disables a card related to microplan estimations, while utility functions for generating campaign strings and updating URL parameters have been refined for better robustness.

Changes

File Path	Change Summary
health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js	- Added MyMicroplanSearchConfigExample, FacilityMappingConfigExample, UserManagementConfigExample, MyMicroplanSearchConfigPlan, FacilityMappingConfigPlan, and UserManagementConfigPlan. - Enhanced methods in MyMicroplanSearchConfig and UserManagementConfig.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js	- Updated mapping to use assigner property for retrieving assignee information instead of assignes.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js	- Enhanced MyMicroplanSearchConfig and UserManagementConfig with new methods and updated logic. - Modified FacilityMappingConfig for new button action.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/ChooseActivity.js	- Temporarily commented out the "VIEW_MICROPLAN_ESTIMATIONS" card from the activityCardData array.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js	- Updated generateCampaignString for improved date formatting. - Enhanced updateUrlParams to delete null/undefined parameters from the URL.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js	- Removed handling of transportationMode, including state variable and associated logic.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/viewVillage.js	- Updated button labels in VillageView to reflect the presence of additional details for security and accessibility.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/PopInboxTable.js	- Added a new column for displaying assignee information in the PopInboxTable.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js	- Introduced a new action type "ROOT_APPROVE" and refined user role management logic.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js	- Removed handling of villageTransportMode from data processing and commented out the corresponding column definition. - Updated actionIconMap to include a new action type ROOT_APPROVE.

Possibly related PRs

• added new hook for microplans search screen #1587: Enhancements to the customValidationCheck method in UserManagementConfig, improving validation processes.
• Added action bar for pop inbox screen #1622: Modifications to additionalCustomizations methods in MicroplanSearchConfig and FacilityMappingConfig, enhancing configuration functionality.
• Summary-screen changes and localization #1672: Updates to the UICustomizations object, focusing on MyMicroplanSearchConfig and UserManagementConfig.
• myMicroplanFixes #1713: Validation logic updates in the EditVillagePopulationPopUp component, related to changes in validation processes.
• Finalised microplan download #1762: Changes to the additionalCustomizations method within MicroplanSearchConfig, enhancing configuration functionality.
• ui fixes #1798: Enhancements to the FacilityMappingConfig section, aligning with the main PR's focus.
• Updated sidebar for microplan #1802: Updates to the health-related CSS version, related to stylesheet modifications.
• updated message for header and label and added validation for max length #1813: Validation logic updates in the EditVillagePopulationPopUp component, related to changes in validation processes.
• Microplan name update #1821: Modifications in the handling of input fields based on certain conditions, related to the main PR.

Suggested reviewers

• nipunarora-eGov

Poem

🐰 In the meadow where changes bloom,
New configs and methods make room.
With validations bright and UI so neat,
Our microplans now dance to a beat!
Hops of joy in every line,
Enhancements made, all is fine! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

🧹 Outside diff range comments (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/ChooseActivity.js (2)

Line range hint 116-127: Enhance error handling and consider code organization.

The error handling in onClickCard only logs to console, which doesn't provide feedback to users when plan updates fail. Additionally, the workflow logic could be extracted for better maintainability.

Consider:

1. Adding user-facing error notifications
2. Extracting workflow logic to a custom hook

Example improvement:

 const onClickCard = async (card) => {
   try {
     if(card.optionKey==="VALIDATE_N_APPROVE_POPULATION_DATA" && planObject.status==="EXECUTION_TO_BE_DONE"){
       await updatePlan({
         ...planObject,
         workflow:{
           action:"START_DATA_APPROVAL"
         }
       });
     }  
   } catch (error) {
-    console.error("ERROR_OCCURED_WHILE_UPDATING_PLAN");
-    console.error(error);
+    Digit.Notify.error(t("ERROR_UPDATING_PLAN"));
+    throw error; // Let error boundary handle it
   }
 }

---

Remove unused MICROPLAN_VIEWER role references

The "MICROPLAN_VIEWER" role appears in two locations:

• In MicroplanCard.js as part of a roles array definition
• In ChooseActivity.js within commented-out code for a disabled viewer functionality

Since the viewer functionality is commented out and disabled, you should:

1. Remove the "MICROPLAN_VIEWER" role from the roles array in MicroplanCard.js
2. Remove the commented-out card code block in ChooseActivity.js to maintain clean and maintainable code

🔗 Analysis chain

Line range hint 48-57: Clean up unused role checks.

Since the microplan viewer functionality is disabled, consider cleaning up related role checks in the isCardDisabled function to maintain code clarity.

Let's verify if the "MICROPLAN_VIEWER" role is used elsewhere in the codebase:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any other usage of the MICROPLAN_VIEWER role
rg -l "MICROPLAN_VIEWER"

Length of output: 225

---

Script:

#!/bin/bash
# Check the usage context of MICROPLAN_VIEWER in MicroplanCard.js
rg -C 5 "MICROPLAN_VIEWER" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/MicroplanCard.js

# Check the usage context in ChooseActivity.js
rg -C 5 "MICROPLAN_VIEWER" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/ChooseActivity.js

Length of output: 1063

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (2)

Line range hint 401-416: Add translation support for error message

The phone number validation looks good, but consider using a translation key for the error message to support internationalization.

 if (!mobileRegex.test(phone)) {
-  return { error: true, label: "INVALID_MOBILE_NUMBER" };
+  return { error: true, label: "ES_ERROR_INVALID_MOBILE_NUMBER" };
 }

---

Remove console.log statements and implement proper error handling

The console.log statements identified in the review comment are still present in the code:

1. A debug statement: console.log(value)
2. A temporary fix: onClick={() => console.log("temp action")} with a comment indicating popup was removed due to crashing

Action items:

• Remove console.log statements from production code
• Properly investigate and fix the popup crashing issue
• Implement proper error handling or user feedback mechanism
• Consider using a logging service for production debugging if needed

🔗 Analysis chain

Line range hint 544-563: Address temporary popup handling solution

The current implementation uses a console.log as a temporary fix for popup issues. This should be properly addressed:

1. Investigate and fix the popup crashing issues
2. Remove console.log statements from production code
3. Implement proper error handling if popup fails

---

The search results show that console.log statements are widely used across the codebase, particularly in:

1. Story files for component documentation/testing
2. Error handling in various components
3. Debug statements in form handling
4. Temporary action handlers

Let me verify if the specific console.log in the review comment is still present.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for other console.log statements that might need cleanup
rg "console\.log" --type js

Length of output: 140115

---

Script:

#!/bin/bash
# Check the specific file for console.log statements
rg "console\.log" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js -A 2 -B 2

Length of output: 519

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between b99b3fa and 927bffe.

📒 Files selected for processing (5)

• health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/ChooseActivity.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/ChooseActivity.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1)

Pattern **/*.js: check

🔇 Additional comments (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

39-40: Verify API compatibility with the assigner property

The change from assignes to assigner property needs verification to ensure API compatibility.

✅ Verification successful

Based on the search results, I can now provide a definitive response about the API property usage:

The change from assignes to assigner is correct and consistent with the codebase

The codebase shows that both properties are used for different purposes:

• assigner: Used for the person who assigned/processed the workflow step (as seen in WorkFlow.js and multiple timeline components)
• assignes: Used for the person(s) to whom the work is assigned (as seen in action modals and workflow services)

The change in the timeline popup is correctly using assigner to show who processed the step, which is consistent with similar usage in:

• WorkFlow.js: assigner: instance?.assigner
• ComplaintDetails.js: name: checkpoint?.assigner?.name
• Other timeline components showing processor details

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for other usages of ProcessInstances API response to verify the property name
# Expected: Find evidence of which property name (assignes/assigner) is used consistently

# Search for ProcessInstances property access patterns
rg -A 3 "ProcessInstances.*\b(assignes|assigner)\b"

# Search for workflow API response handling
ast-grep --pattern 'ProcessInstances.{
  $$$
  assigner
  $$$
}'

Length of output: 120

---

Script:

#!/bin/bash
# Let's try a broader search for the property names in the codebase

# Search for assignes/assigner property access patterns in JS files
rg -t js "\b(assignes|assigner)\b" -A 3

# Search for workflow-related files that might contain these patterns
fd -e js -e json . | grep -i "workflow\|process"

# Search for API response handling patterns
ast-grep --pattern '{
  $$$
  assigner: $_
  $$$
}'

Length of output: 27779

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1)

285-285: LGTM! Clean and internationalization-ready implementation.

The template literal provides a clear and maintainable way to construct the campaign string, with proper internationalization support for all components.

health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js (1)

985-985: 🧹 Nitpick (assertive)

Consider using a CSS class instead of inline styles for button widths

The inline style={{minWidth:"200px"}} is applied to multiple ButtonNew components. To improve maintainability and consistency, consider defining a CSS class and applying it to these buttons.

Also applies to: 996-996, 1006-1006

⛔ Skipped due to learnings

Learnt from: nabeelmd-eGov
PR: egovernments/DIGIT-Frontend#1680
File: health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js:1032-1094
Timestamp: 2024-11-12T10:40:17.779Z
Learning: In the DIGIT-Frontend project, when reviewing the `UICustomizations.js` file, avoid suggesting refactoring of repetitive rendering logic in switch cases into helper functions, unless explicitly requested.

[coderabbitai]

Actionable comments posted: 7

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (2)

Line range hint 132-141: Remove commented JSX block.

Remove the entire commented-out transportation mode dropdown section for better code maintainability.

Apply this diff:

- {/* <LabelFieldPair>
-   <div className="edit-label">{t(`HCM_MICROPLAN_VILLAGE_TRANSPORTATION_MODE_LABEL`)}</div>
-   <Dropdown
-     option={[{ name: "OTHER", code: "OTHER" }]} // Your options list
-     optionKey="name"
-     selected={dropdown3Value}
-     select={(value) => handleDropdownChange(value, "dropdown3")}
-     t={t}
-   />
- </LabelFieldPair> */}

---

Line range hint 91-98: Enhance error handling and validation.

Consider these improvements to make the component more robust:

1. Add validation for required fields before save
2. Implement more specific error messages based on API error codes
3. Add loading state handling during API calls

Example implementation:

  const handleSave = async () => {
+   if (!dropdown1Value || !dropdown2Value) {
+     setShowToast({ key: "error", label: t("HCM_REQUIRED_FIELDS_MISSING") });
+     return;
+   }
    await mutation.mutate(
      {
        body: reqPayload,
      },
      {
        onSuccess: (data) => {
          onSuccess && onSuccess(data);
+         setShowToast({ key: "success", label: t("HCM_SAVE_SUCCESS") });
        },
        onError: (error) => {
-         setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+         const errorCode = error?.response?.data?.Errors?.[0]?.code || "HCM_UNKNOWN_ERROR";
+         setShowToast({ key: "error", label: t(errorCode) });
        }
      }
    );
  };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 927bffe and 774b583.

📒 Files selected for processing (4)

• health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (6 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/viewVillage.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/viewVillage.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/viewVillage.js (1)

300-304: LGTM! Button improvements enhance usability.

The changes improve the button's usability through:

1. Proper translation key implementation
2. Better visibility with medium size
3. Appropriate conditional rendering based on available actions

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/UICustomizations.js (1)

270-270: Consider using design tokens for button widths

While setting a consistent minWidth improves UI consistency, consider using design tokens or CSS variables instead of hardcoded pixel values for better maintainability and responsive design.

Also applies to: 280-280, 290-290

[coderabbitai]

Actionable comments posted: 5

🧹 Outside diff range comments (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

Line range hint 1-67: Consider architectural improvements

A few suggestions to improve the component's architecture:

1. Memoize the timeline steps construction to prevent unnecessary recalculations
2. Add error handling for the API hook
3. Consider adding TypeScript types for better type safety

Example implementation for memoization:

const getTimelineSteps = React.useCallback((workflowData) => {
  if (!workflowData?.ProcessInstances) return [];
  
  return workflowData.ProcessInstances.map((instance) => ({
    label: t(instance?.action),
    variant: 'completed',
    subElements: [
      Digit.Utils.microplanv1.epochToDateTime(instance?.auditDetails?.lastModifiedTime),
      instance?.assigner
        ? `${instance.assigner.name} - ${instance.assigner.roles?.[0]?.name || 'NA'}`
        : 'NA',
      instance.comment
        ? `${t('COMMENT_PREFIX')} "${instance.comment}"`
        : null
    ].filter(Boolean),
    showConnector: true
  }));
}, [t]);

useEffect(() => {
  setTimelineSteps(getTimelineSteps(workflowData));
}, [workflowData, getTimelineSteps]);

Would you like me to help with implementing these improvements?

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (3)

Line range hint 63-64: Consider moving role checks to a utility function

The role check logic could be moved to a separate utility function for better maintainability and reusability.

-const isRootApprover = userRoles?.includes("ROOT_POPULATION_DATA_APPROVER");
+const ROLES = {
+  ROOT_APPROVER: "ROOT_POPULATION_DATA_APPROVER"
+};
+
+const hasRole = (roles, roleToCheck) => roles?.includes(roleToCheck);
+const isRootApprover = hasRole(userRoles, ROLES.ROOT_APPROVER);

---

Line range hint 329-341: Add validation for workflow state transitions

The workflow update function should validate if the transition is allowed based on the current state.

 const updateWorkflowForSelectedRows = () => {
+  // Validate if transition is allowed
+  const isValidTransition = selectedRows?.every(census => {
+    const currentState = census.workflow?.state;
+    return workflowData?.states
+      ?.find(state => state.state === currentState)
+      ?.actions?.some(action => action.action === workFlowPopUp);
+  });
+
+  if (!isValidTransition) {
+    throw new Error("Invalid workflow transition");
+  }
+
   const updatedRows = selectedRows?.map((census) => ({
     ...census,
     workflow: {
       ...census.workflow,
       action: workFlowPopUp,
     },
   }));
   return updatedRows;
 };

---

Line range hint 573-589: Add loading state for workflow actions

The WorkflowCommentPopUp component should show loading state during API calls to prevent multiple submissions.

 <WorkflowCommentPopUp
   onClose={closeActionBarPopUp}
   heading={t(`HCM_MICROPLAN_FINALIZE_POPULATION_DATA_LABEL`)}
   submitLabel={t(`HCM_MICROPLAN_FINALIZE_POPULATION_DATA_SUBMIT_ACTION`)}
   url="/plan-service/config/_update"
   requestPayload={{ PlanConfiguration: updateWorkflowForFooterAction() }}
   commentPath="workflow.comments"
+  isLoading={isSubmitting}
   onSuccess={(data) => {
     history.push(`/${window.contextPath}/employee/microplan/population-finalise-success`, {
       fileName: data?.PlanConfiguration?.[0]?.name,
       message: t(`POPULATION_FINALISED_SUCCESSFUL`),
       back: t(`GO_BACK_TO_HOME`),
       backlink: `/${window.contextPath}/employee`
     });
   }}
   onError={(data) => {
-    setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+    const errorMessage = error?.response?.data?.Errors?.[0]?.message || t("DEFAULT_ERROR_MESSAGE");
+    setShowToast({ key: "error", label: errorMessage });
   }}
 />

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 774b583 and 8caba8d.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/PopInboxTable.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/PopInboxTable.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Line range hint 1-607: Verify workflow transitions in the codebase

Let's verify that all possible workflow transitions are properly handled.

✅ Verification successful

Let me gather more specific information about the workflow transitions in the microplan module.

---

Based on the search results, I can now verify the workflow transitions in the codebase. The code shows a well-structured workflow system with proper state management and transitions. Here's my final response:

Workflow transitions are properly implemented and verified

The codebase demonstrates proper handling of workflow transitions with:

• Clear state definitions: DRAFT, EXECUTION_TO_BE_DONE, CENSUS_DATA_APPROVAL_IN_PROGRESS, CENSUS_DATA_APPROVED, etc.
• Role-based action controls through availableActionsForUser
• Proper workflow action updates via updateWorkflowForSelectedRows() and updateWorkflowForFooterAction()
• Status validation through isStatusConditionMet() before allowing transitions
• Appropriate action handlers like handleActionClick() and handleActionBarClick()

The review comment's concern about workflow transitions is properly addressed in the implementation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check workflow transitions and action handlers

# Search for workflow state definitions
echo "Searching for workflow state definitions..."
ast-grep --pattern 'state: $state {
  $$$
  actions: [
    $$$
  ]
}'

# Search for workflow action handlers
echo "Searching for workflow action handlers..."
rg -A 5 'workflow.*action.*='

Length of output: 8719

---

Script:

#!/bin/bash
# Search for workflow-related code in the microplan module
echo "Searching for workflow transitions in microplan module..."
rg -A 5 "workflow.*action" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/

# Search for workflow state definitions in microplan
echo "Searching for workflow state definitions in microplan..."
rg -A 10 "status.*=.*" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/

# Search for action handlers in PopInbox.js
echo "Searching for action handlers in PopInbox.js..."
rg -A 5 "handleAction|updateWorkflow" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js

Length of output: 68522

[coderabbitai]

Actionable comments posted: 3

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

Line range hint 14-24: Add error handling for API failures

The custom API hook implementation lacks error handling. API failures should be properly handled and displayed to users.

Consider adding error handling:

     const { isLoading, data: workflowData, revalidate } = Digit.Hooks.useCustomAPIHook({
         url: "/egov-workflow-v2/egov-wf/process/_search",
         params: {
             tenantId: tenantId,
             history: true,
             businessIds: businessId,
         },
         config: {
             enabled: true,
+            onError: (error) => {
+                Digit.Utils.notificationHandler.error(t("ES_COMMON_ERR_FETCHING_WORKFLOW"));
+            }
         },
     }
     );

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 1-635: Consider broader code cleanup

While the changes look good, there are several other commented code blocks throughout the file (e.g., around lines 402-413). Consider a broader cleanup to remove all commented code sections and improve overall code maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 8caba8d and e1720ed.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/timelinePopUpWrapper.js (1)

39-41: Previous review comments are still applicable

The code segment still has the same issues that were pointed out in the previous reviews regarding error handling, code style, and template literal usage.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

486-486: Verify workflow handling for ROOT_APPROVE action

The addition of ROOT_APPROVE action looks good and follows the existing pattern. However, please ensure that:

1. The workflow state machine properly handles this new action
2. Appropriate permissions are set for users who can trigger this action
3. The action is properly handled in the workflow update logic

#!/bin/bash
# Search for ROOT_APPROVE handling in workflow definitions and related files
rg -A 5 "ROOT_APPROVE" -g '*.js' -g '*.json'

# Search for workflow state definitions to verify proper integration
ast-grep --pattern 'workflow: { $$$, action: "ROOT_APPROVE", $$$ }'