-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update] PartSiteInformation fix BPNS reference #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation Report for io.catenax.shared.part_site_information_as_built/1.1.0/PartSiteInformationAsBuilt.ttlInput model is valid |
but waiting for #571 for updated regex to also include this |
This was referenced Jan 30, 2024
Validation Report for io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttlValidation failed: |
Validation Report for io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttlValidation failed: |
Validation Report for io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttlInput model is valid |
@agg3fe then this patch (+ samm update) is also ready |
Validation Report for io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttlInput model is valid |
agg3fe
reviewed
Feb 1, 2024
io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttl
Outdated
Show resolved
Hide resolved
agg3fe
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.shared.part_site_information_as_built/2.0.0/PartSiteInformationAsBuilt.ttlInput model is valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
model didn't used to link to the tait of BPNS (only to the characterisitc) --> fixed
Closes #
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)