-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: SerialPart 3.0.0 #557
[Model Update]: SerialPart 3.0.0 #557
Conversation
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
modeling_team |
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
@agg3fe Changes were made like recommended. |
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
@@ -0,0 +1,206 @@ | |||
####################################################################### | |||
# Copyright(c) 2024 BASF SE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be 2022-2024? (you had 2022,2023 in the 1.0.0)
@johannsvarela could you please fix the issues found by Carolin. |
@prefix : <urn:samm:io.catenax.serial_part:3.0.0#>. | ||
@prefix ext-built: <urn:samm:io.catenax.shared.part_site_information_as_built:1.0.0#>. | ||
@prefix ext-classification: <urn:samm:io.catenax.shared.part_classification:1.0.0#>. | ||
@prefix ext-uuid: <urn:samm:io.catenax.shared.uuid:1.0.0#>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use uuid 2.0.0
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
1 similar comment
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
Validation Report for io.catenax.serial_part/3.0.0/SerialPart.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Based on the continous development of the Industry Core, there are a new data, that needs to be integrated in the SerialPart aspect model. Therefore these extensions / adaptations were made:
Closes #552 --> Deprecation of the old version (#612) should be done after this PR was merged!
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)