[Model Update]: return request_v2.0.0 #483

yuchengluo1 · 2023-11-26T15:54:28Z

Description

As mentioned in issue: #313.

-->

Closes #313

MS2 Criteria

(to be filled out by PR reviewer)

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

All required reviewers have approved this PR (see reviewers section)
The new aspect (version) will be implemented by at least one data provider
The new aspect (version) will be consumed by at least one data consumer
There exists valid test data
In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
The model has at least version '1.0.0'
If a previous model exists, model deprecation has been checked for previous model
The release date in the Release Note is set to the date of the MS3 approval

github-actions · 2023-11-26T15:55:15Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe · 2023-11-28T10:42:30Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+:quantity a samm:Property ;
+   samm:preferredName "quantity"@en ;
+   samm:description "The desired quantity of the on the marketplace offered product in SKU."@en ;
+   samm:characteristic :QuantityCharacteristic ;


for quantity, please check if you can make use of existing shared quantity model , then you don't need to define your own Characteristic. Example here

github-actions · 2023-11-29T18:01:48Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe · 2023-12-01T09:55:20Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+:startDate a samm:Property ;
+   samm:preferredName "start date"@en ;
+   samm:description "The first day of the period"@en ;
+   samm:characteristic samm-c:Timestamp ;


the value for characteristic should be DateTimestamp here instead of samm-c:Timestamp, else the example value is not correct.

agg3fe · 2023-12-01T09:56:30Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+:endDate a samm:Property ;
+   samm:preferredName "end date"@en ;
+   samm:description "The last day of the period."@en ;
+   samm:characteristic samm-c:Timestamp ;


here also, value should be DateTimestamp

agg3fe · 2023-12-01T09:58:36Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+
+:isRecall a samm:Property ;
+   samm:preferredName "is recall"@en ;
+   samm:description "Depicts if the manufacturer issued a recall (e.g. for security reasons). In concjunction with property needsReturn it can be expressed if the item has to be returned or can directly be destroyed."@en ;


typo concjunction

agg3fe · 2023-12-01T10:00:00Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+   samm:exampleValue "PODBS39HZ7382HDG28" .
+
+:Mileage a samm-c:Measurement ;
+   samm:preferredName "mileage"@en ;


please add description here

agg3fe · 2023-12-01T10:02:35Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+:mileage a samm:Property ;
+   samm:preferredName "mileage"@en ;
+   samm:description "Current mileage of the component"@en ;
+   samm:characteristic :Mileage ;


Property and the referenced Characteristic should not have the same name

agg3fe

please check my comments

github-actions · 2023-12-05T15:01:19Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe

LGTM

github-actions · 2024-01-29T13:59:50Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

catroest · 2024-01-29T13:27:59Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

@@ -0,0 +1,245 @@
+#######################################################################
+# Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft


All of them will be changed to 2023-2024.

catroest · 2024-01-29T13:31:07Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+# SPDX-License-Identifier: CC-BY-4.0
+#######################################################################
+
+@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.0.0#> .


Should all the version the eclipse-related prefix be changed to 2.1.0 or just necessary for this meta-model?
As far as I understand, for making this change I would have to also upgrade my Aspect-Model-Editor to a new version, otherwise I cannot open the model after the changeis done. Is it correct?

correct, all four have to reference 2.1.0 (which will automatically happen if you open and save it in the new version of the editor)
All updated/new models are 2.1.0

catroest · 2024-01-29T14:04:31Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+   samm:description "The desired quantity of the on the marketplace offered product in SKU."@en ;
+   samm:characteristic ext-quantity:ItemQuantityCharacteristic .
+
+:unitOfMeasure a samm:Property ;


this is redundant, as quantity (the shared aspect) also refers to a value and unit. Therefore maybe adapt the description of the quantity property to corrctly describe what is following in the structure below.

catroest · 2024-01-29T14:11:18Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+   samm:characteristic samm-c:Text ;
+   samm:exampleValue "8O8RKJZ7ER" .
+
+:serialNumber a samm:Property ;


use of serialPart (localIdentifiers)

Is a simple change of naming sufficient? (serialNumber->localIdentifiers)

I mean the use of the aspect serial part. Best to open the serial part model seperatly to see the redundant fields which can be linked.

If the aspect serial part is used, then more shared aspects are linked in the model (shared.part_site_information_as_built, business_partner_number, etc.). This means that the prefix in these shared aspect involved also needs to be updated to eclipse 2.1.0 version. I will submit multiple PRs to apply for these changes. Is it ok?

These will be updated anyway to 2.1.0 due to recent changes (#557 #581 #571). You can include the current version already, but be aware to change the prefix to the higher version before the PR is merged.

catroest · 2024-01-29T14:12:22Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+   samm:characteristic :DateTimestamp ;
+   samm:exampleValue "2030-09-30"^^xsd:date .
+
+:manufacturingPartID a samm:Property ;


use of serialPart (e.g manufacturerPartId)

Is a simple change of naming sufficient? (manufacturingPartID->manufacturerPartId)

I mean the use of the aspect serial part

io.catenax.return_request/2.0.0/ReturnRequest.ttl

catroest · 2024-01-29T14:43:25Z

generally see requirements from the industry core @jonbckr

catroest · 2024-01-29T14:46:40Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+# Copyright (c) 2023 ZF Friedrichshafen AG
+# Copyright (c) 2023 Circular Economy Solutions GmbH (C-ECO)
+# Copyright (c) 2023 T-Systems International GmbH
+# Copyright (c) 2023 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V.


Contributers to Eclipse Foundation missing

agg3fe · 2024-01-30T10:38:21Z

@yuchengluo1 request you to resolve the comments given by Carolin.

github-actions · 2024-01-30T15:37:59Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

yuchengluo1 · 2024-01-30T15:38:28Z

All the requested adjustments are now fullfilled.

catroest · 2024-01-30T16:38:51Z

Please look at the comments of the industry core here:

I think there are still some unresolved topics.
https://miro.com/app/board/uXjVMiC7vAc=/?moveToWidget=3458764571585802082&cot=14

yuchengluo1 · 2024-01-31T08:16:47Z

@catroest I cannot open the miro webpage since it requires a password.

jonbckr · 2024-01-31T08:33:34Z

@catroest I cannot open the miro webpage since it requires a password.

The PW is networkofnetwork :)

yuchengluo1 · 2024-01-31T09:29:45Z

@catroest 1 question regarding the property "productGroup": Is it ok to use this name and link it with ClassificationCharacteristic from shared aspect part_classification? Or I should partClassification property directly?

catroest · 2024-01-31T10:45:48Z

@catroest 1 question regarding the property "productGroup": Is it ok to use this name and link it with ClassificationCharacteristic from shared aspect part_classification? Or I should partClassification property directly?

Both would be possible. If you link to the Characteristic you could describe you property yourself. Otherwise you take over the description of the partClassification property. As your descriptions are very similiar, I would suggest the "cleaner" version and link to the property, then you do not have to describe the property again.

agg3fe · 2024-01-31T11:51:06Z

@yuchengluo1 let me know when the model is ready for MS2 check again.

github-actions · 2024-01-31T12:52:57Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

yuchengluo1 · 2024-01-31T12:53:06Z

You may check now, thanks.

agg3fe · 2024-02-05T15:04:00Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+@prefix : <urn:samm:io.catenax.return_request:2.0.0#> .
+@prefix ext-characteristic: <urn:samm:io.catenax.shared.address_characteristic:3.0.0#> .
+@prefix ext-classification: <urn:samm:io.catenax.shared.part_classification:1.0.0#> .
+@prefix ext-part: <urn:samm:io.catenax.serial_part:2.0.0#> .


please update the version to 3.0.0

@yuchengluo1 please change version of serial_part to 3.0.0. you will first need to update your PR with main branch.

agg3fe · 2024-02-05T15:04:09Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+@prefix ext-characteristic: <urn:samm:io.catenax.shared.address_characteristic:3.0.0#> .
+@prefix ext-classification: <urn:samm:io.catenax.shared.part_classification:1.0.0#> .
+@prefix ext-part: <urn:samm:io.catenax.serial_part:2.0.0#> .
+@prefix ext-quantity: <urn:samm:io.catenax.shared.quantity:1.0.0#> .


quantity 2.0.0

github-actions · 2024-02-05T15:21:11Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe · 2024-02-06T15:09:48Z

io.catenax.return_request/2.0.0/ReturnRequest.ttl

+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix : <urn:samm:io.catenax.return_request:3.0.0#> .


Why you have changed return_request version to 3.0.0?

sorry, wrong touch

agg3fe

please make commented changes before merge.

github-actions · 2024-02-07T10:04:39Z

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe

LGTM

return request Model Update

24e0f3a

agg3fe reviewed Nov 28, 2023

View reviewed changes

update shared quantity certificate

ea2be19

agg3fe reviewed Dec 1, 2023

View reviewed changes

agg3fe requested changes Dec 1, 2023

View reviewed changes

adjustments acc. to admin

aa24849

agg3fe approved these changes Jan 18, 2024

View reviewed changes

agg3fe added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Jan 18, 2024

date update

9eabb54

catroest suggested changes Jan 29, 2024

View reviewed changes

catroest reviewed Jan 29, 2024

View reviewed changes

agg3fe removed the MS2_Approved Checklist "MS2 Valid Model" is approved. label Jan 30, 2024

model update

df6380a

update based on industry core

e51db31

agg3fe added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Jan 31, 2024

agg3fe reviewed Feb 5, 2024

View reviewed changes

agg3fe added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Feb 5, 2024

update

419f968

agg3fe reviewed Feb 6, 2024

View reviewed changes

agg3fe requested changes Feb 6, 2024

View reviewed changes

update

2734e36

agg3fe approved these changes Feb 7, 2024

View reviewed changes

agg3fe merged commit e8db526 into eclipse-tractusx:main Feb 7, 2024
4 checks passed

		@@ -0,0 +1,245 @@
		#######################################################################
		# Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft

[Model Update]: return request_v2.0.0 #483

[Model Update]: return request_v2.0.0 #483

Conversation

yuchengluo1 commented Nov 26, 2023 • edited by agg3fe Loading

Description

MS2 Criteria

MS3 Criteria

github-actions bot commented Nov 26, 2023

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2023

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agg3fe left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2023

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 29, 2024

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catroest Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catroest commented Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

agg3fe commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

yuchengluo1 commented Jan 30, 2024

catroest commented Jan 30, 2024

yuchengluo1 commented Jan 31, 2024 • edited Loading

jonbckr commented Jan 31, 2024

yuchengluo1 commented Jan 31, 2024

catroest commented Jan 31, 2024

agg3fe commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

yuchengluo1 commented Jan 31, 2024

Choose a reason for hiding this comment

agg3fe Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2024

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agg3fe left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 7, 2024

Validation Report for io.catenax.return_request/2.0.0/ReturnRequest.ttl

Input model is valid

agg3fe left a comment

Choose a reason for hiding this comment

yuchengluo1 commented Nov 26, 2023 •

edited by agg3fe

Loading

catroest Jan 29, 2024 •

edited

Loading

catroest commented Jan 29, 2024 •

edited

Loading

yuchengluo1 commented Jan 31, 2024 •

edited

Loading

agg3fe Feb 6, 2024 •

edited

Loading