-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BusinessPartnerNumber): adjusted regex to match CX-0010 #571
fix(BusinessPartnerNumber): adjusted regex to match CX-0010 #571
Conversation
Validation Report for io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttlInput model is valid |
io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
@@ -1,6 +1,16 @@ | |||
# Changelog | |||
All notable changes to this model will be documented in this file. | |||
|
|||
## [2.0.0] - 2024-01-XY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20204-02-05 hopefully?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Validation Report for io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttlInput model is valid |
io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
@tom-rm-meyer-ISST are we ready for this model? I will directly merge it. let me know. |
Validation Report for io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@agg3fe, model is ready from my point of view |
Validation Report for io.catenax.shared.business_partner_number/2.0.0/BusinessPartnerNumber.ttlInput model is valid |
Description
-->
Closes #570
Did not include SAMM update
Major version update needed? Overall it's less restricitve why it could also be a minor version change
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)