-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model] Transmission #116
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed typos and casing, where applicable - updated link for SAMM Unit Catalog to a more stable one
… into Transmission
Add single level bom as planned 1.1.0 (based on work of PR#101)
Add part as planned 1.0.1 (based on work of PR#87)
[Model Update] version update: Physical Dimensions
[Model Update] version update: Contact
[Model Update] version update: Address
[New Model] Week-Based Capacity Group (Demand and Capacity Management)
[New Model] Week-Based Material Demand (Demand and Capacity Management)
…-planned-1.1.0 Single level usage as planned 1.1.0
fixed preferred name fixed whitespace
external namespaces deleted as of now (will be added later) StringLists fixed and made more specific RecyclateContent still open
Fix typo pysical-c to physical-c to allow model to validate
bs-jokri
suggested changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further findings. Please check
:physicalDimensions a bamm:Property; | ||
bamm:preferredName "physical dimensions"@en; | ||
bamm:description "Describing the physical dimensions without packaging."@en; | ||
bamm:characteristic pysical-c:PhysicalDimensionsCharacteristic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is not fixed
change to physical-c:PhysicalDimensionsCharacteristic
initiated again in PR #132 |
bs-jokri
added
MS2_Approved
Checklist "MS2 Valid Model" is approved.
and removed
MS2_Approved
Checklist "MS2 Valid Model" is approved.
labels
Mar 31, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-->
Closes #93
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)