-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single level usage as planned 1.1.0 #102
Single level usage as planned 1.1.0 #102
Conversation
- fixed typos and casing, where applicable - updated link for SAMM Unit Catalog to a more stable one
modeling_team |
|
fixed MS2 findings |
@bs-jokri now all good, please approve MS2. |
# Copyright (c) 2022 Siemens AG | ||
# Copyright (c) 2022 T-Systems International GmbH | ||
# Copyright (c) 2022 ZF Friedrichshafen AG | ||
# Copyright (c) 2022 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catroest copyright updated
[x] All required reviewers have approved this PR (see reviewers section) MS3 approved please merge @bs-jokri |
Description
We need to update this Aspect to include all Part versions and validity (asPlanned) to cover the versioning of components and vehicles.
Added
Changed
-->
Closes #74
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)