-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model] Transmission Pass #132
Conversation
Fix typo in property name
@catroest could you have a look into my comments? I found minor things, which not hinder ms2 but might be good to be fixed. |
Yes, I read every comment and I think I fixed everything. The only thing I would like to keep are the property prferred name. I would like to keep only the first word as uppercase. This is because I often use the same name for the property and the description, I wouldn't like for the preferred names to be the same. Do you mean something else? |
Modeling_Team ready for MS3 |
link to pcf 3.0.0 (to be released)
before merge into main:
|
Description
Integrates comments from #112 and #116
-->
Closes #93
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)