Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model] Week-Based Capacity Group (Demand and Capacity Management) #91

Merged
merged 10 commits into from
Mar 27, 2023

Conversation

LukasHeimann
Copy link
Contributor

@LukasHeimann LukasHeimann commented Mar 2, 2023

Description

This aspect contains data about a Capacity Group of a given supplier for a particular customer. It is necessary for the use case of Demand and Capacity Management (DCM), representing the "Capacity" part of the use case. A parallel request has been opened for the corresponding model of a Material Demand as shared by the customer (#92). Both models co-evolve.

In DCM, customers along a supply chain want to make the demands for their materials at certain locations with certain demand categories available for their suppliers. Demand data is provided on a weekly basis for the next two years. Suppliers, in return make their capacities for certain demand series (based on material, location and demand category) transparent to the respective customers.

Compare

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The BAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "name" and "description" in English language.
  • no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the BAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'

Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bs-jokri bs-jokri added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Mar 2, 2023
@LukasHeimann
Copy link
Contributor Author

Thank you for reviewing and approving! Please wait with merging until the use case gave their final okay as well.

@bs-jokri
Copy link
Contributor

bs-jokri commented Mar 2, 2023

same comment as here: #92 (comment)

@LukasHeimann LukasHeimann changed the title [New Model] Capacity Group (Demand and Capacity Management) [New Model] Week-Based Capacity Group (Demand and Capacity Management) Mar 6, 2023
@petyog petyog added the Modeling Team This issue or PR should be discussed in the modeling team. label Mar 20, 2023
@bs-jokri bs-jokri added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Mar 20, 2023
@petyog
Copy link
Contributor

petyog commented Mar 27, 2023

@bs-jokri are there still any open tasks / pending checks or can this PR be merged? We need the final link to the WeekBasedCapacityGroup.ttl file for the corresponding standardization request (CX-0047).

@bs-jokri
Copy link
Contributor

@petyog automatic tests are completed and PR is merged. You can find the model in the main branch

@bs-jokri bs-jokri merged commit da01fd4 into eclipse-tractusx:main Mar 27, 2023
@LukasHeimann LukasHeimann deleted the dcm-capacityGroup branch March 28, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modeling Team This issue or PR should be discussed in the modeling team. MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants