Fix correctly setting Find-Scopes when opening Find/Replace-Dialog #1819 #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 921 files ±0 921 suites ±0 1h 13m 31s ⏱️ - 1m 10s For more details on these failures, see this check. Results for commit e9340dc. ± Comparison against base commit 3c12155. ♻️ This comment has been updated with latest results. |
Wittmaxi
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
2 times, most recently
from
493da29 to
ddd9a5e
Compare
HeikoKlare
reviewed
Apr 19, 2024
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Outdated
Show resolved
Hide resolved
...se.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/IFindReplaceLogic.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
from
ddd9a5e to
d2b7626
Compare
HeikoKlare
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
2 times, most recently
from
f583f7d to
2c2428a
Compare
HeikoKlare
reviewed
Apr 21, 2024
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Outdated
Show resolved
Hide resolved
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Outdated
Show resolved
Hide resolved
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
from
2c2428a to
4f96a6e
Compare
HeikoKlare
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
from
4f96a6e to
e50b59c
Compare
…lipse-platform#1819 This PR correctly disables SearchOptions.GLOBAL in the FindReplaceLogic object of the Dialog if a multiline-selection was selected while opening the Find/Replace-Dialog. This PR also provides a unit-test for this behavior. Fixes eclipse-platform#1819
HeikoKlare
force-pushed
the
MW_FindReplaceDialog_AreaSearch_On_Selection
branch
from
e50b59c to
e9340dc
Compare
HeikoKlare
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Great, thank you! Failing test is unrelated and documented in #926.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly disables SearchOptions.GLOBAL in the FindReplaceLogic object of the Dialog if a multiline-selection was selected while opening the Find/Replace-Dialog.
This PR also provides a unit-test for this behavior.
See #1819