Incremental Search: extract logic for disabling on RegEx-Search #1791

[Wittmaxi]

when "incremental search" is selected and "RegEx-Search" is as well, the dialog/overlay will disable the option for "whole words". This PR extracts that functionality into the Find/Replace-Logic.

Extracted from a Review-Comment in #1791

[github-actions]

Test Results

   921 files     921 suites   46m 9s ⏱️
 7 518 tests  7 367 ✅ 151 💤 0 ❌
23 706 runs  23 199 ✅ 507 💤 0 ❌

Results for commit 9b783e9.

♻️ This comment has been updated with latest results.

[Wittmaxi]

Random Fail for Ubuntu is reported here: #1808
Random Fail for Mac is reported here: #811
Random Fail for Windows is reported here: #1427

[HeikoKlare]

In general, this looks good. I have two minor comments.

[HeikoKlare]

And could you please also adapt the commit message, just like for the "whole words" options? (see #1791 (comment))

[Wittmaxi]

@HeikoKlare Addressed in d654b06

[fedejeanne]

Minor improvement in a test name desired

[HeikoKlare]

The current state produces a regression, as the dialog can loose its "incremental" option when reopened. To reproduce, activate the "incremental" option, activate and deactive the "regex" option, then close and re-open the dialog. The "incremental" option is unselected but it selection should be recovered from the previous session of the dialog.

This is because the change misses an update of the functionality in FindReplaceDialog.setupFindReplaceLogic(), which still bases the activation of the "incremental" option on its selection and its enablement. The latter has to be removed, just like for the "whole word" option.

eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

Lines 1267 to 1268 in 781d89e

	activateInFindReplaceLogicIf(SearchOptions.INCREMENTAL,
	fIncrementalCheckBox.getEnabled() && fIncrementalCheckBox.getSelection());

[fedejeanne]

The current state produces a regression ...

Now that you mention it, I'm pretty sure one can find some other weird behaviors when playing with "Incremental", "Whole words" and "Regular expressions" and closing + reopening the search dialog :-o

[HeikoKlare]

Now that you mention it, I'm pretty sure one can find some other weird behaviors when playing with "Incremental", "Whole words" and "Regular expressions" and closing + reopening the search dialog :-o

Can you elaborate on that? Is there something specific you have in mind and is that a general negative expectation or related to this PR?

[fedejeanne]

Now that you mention it, I'm pretty sure one can find some other weird behaviors when playing with "Incremental", "Whole words" and "Regular expressions" and closing + reopening the search dialog :-o

Can you elaborate on that? Is there something specific you have in mind and is that a general negative expectation or related to this PR?

Sorry for being unclear. I wasn't talking about this PR :-)

[Wittmaxi]

@HeikoKlare I have addressed your comment and added a Unit-Test which checks the behavior for "re-opening" the dialog.
A very large amount of improvements in testing-architecture were made in the Find/Replace-Overlay-PR, so once that is moved, we should test the "re-opening"-behavior of the Dialog/Overlay with the other buttons

[Wittmaxi]

Windows Random Failing documented here: #1807

[HeikoKlare]

Failing checks because of new issues are only because of an outdated reference build. Recent master build reports the same new issues: https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/master/422