Fix correctly setting Find-Scopes when opening Find/Replace-Dialog #1819

This PR correctly disables SearchOptions.GLOBAL in the FindReplaceLogic
object of the Dialog if a multiline-selection was selected while opening
the Find/Replace-Dialog.

This PR also provides a unit-test for this behavior.

See #1819

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/IFindReplaceLogic.java

@@ -68,7 +68,7 @@ public interface IFindReplaceLogic {
 
 	/**
 	 * {@return whether incremental search may be performed by the
-	 * find/replace-logic based on the currently active options}
+	 * find/replace-logic based on the currently active options.}
 	 */
 	public boolean isIncrementalSearchAvailable();
 

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

@@ -943,6 +943,7 @@ private void initFindStringFromSelection() {
 		} else {
 			fGlobalRadioButton.setSelection(false);
 			fSelectedRangeRadioButton.setSelection(true);
+			findReplaceLogic.deactivate(SearchOptions.GLOBAL);
 		}
 	}
 

tests/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java

@@ -98,6 +98,8 @@ private class DialogAccess {
 
 		private Runnable closeOperation;
 
+		public Button replaceAllButton;
+
 
 		DialogAccess(Accessor findReplaceDialogAccessor, boolean checkInitialConfiguration) {
 			findReplaceLogic= (FindReplaceLogic) findReplaceDialogAccessor.get("findReplaceLogic");
@@ -110,6 +112,7 @@ private class DialogAccess {
 			incrementalCheckBox= (Button) findReplaceDialogAccessor.get("fIncrementalCheckBox");
 			regExCheckBox= (Button) findReplaceDialogAccessor.get("fIsRegExCheckBox");
 			replaceFindButton= (Button) findReplaceDialogAccessor.get("fReplaceFindButton");
+			replaceAllButton= (Button) findReplaceDialogAccessor.get("fReplaceAllButton");
 			shellRetriever= () -> ((Shell) findReplaceDialogAccessor.get("fActiveShell"));
 			closeOperation= () -> findReplaceDialogAccessor.invoke("close", null);
 			if (checkInitialConfiguration) {
@@ -426,6 +429,19 @@ public void testActivateWholeWordsAndSearchForTwoWords() {
 		assertFalse(dialog.wholeWordCheckBox.getEnabled());
 	}
 
+	@Test
+	public void testActivateDialogWithSelectionActive() {
+		openTextViewer("text" + System.lineSeparator() + "text" + System.lineSeparator() + "text");
+		fTextViewer.setSelectedRange(5, 9);
+		openFindReplaceDialogForTextViewer(false);
+
+		assertFalse(dialog.globalRadioButton.getSelection());
+		dialog.findCombo.setText("text");
+		dialog.replaceAllButton.notifyListeners(SWT.Selection, null);
+
+		assertEquals(fTextViewer.getDocument().get(), "text" + System.lineSeparator() + System.lineSeparator());
+	}
+
 	@Test
 	public void testIncrementalSearchOnlyEnabledWhenAllowed() {
 		openTextViewer("text text text");