Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random failing of HoverTest.testEnabledWhenHover() #926

Open
fedejeanne opened this issue Jul 10, 2023 · 1 comment
Open

Random failing of HoverTest.testEnabledWhenHover() #926

fedejeanne opened this issue Jul 10, 2023 · 1 comment
Labels
help wanted Extra attention is needed test junit test related things

Comments

@fedejeanne
Copy link
Contributor

The test HoverTest.testEnabledWhenHover() failed for Linux in this build of #755 .

org.eclipse.ui.genericeditor.tests.HoverTest.testEnabledWhenHover -- Time elapsed: 12.51 s <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.fail(Assert.java:96)
	at org.eclipse.ui.genericeditor.tests.HoverTest.getHoverShell(HoverTest.java:175)
	at org.eclipse.ui.genericeditor.tests.HoverTest.testEnabledWhenHover(HoverTest.java:90)
@zelenyhleb zelenyhleb mentioned this issue Jul 26, 2023
Merged
@BeckerWdf BeckerWdf mentioned this issue Jul 26, 2023
Merged
@HeikoKlare HeikoKlare mentioned this issue Jul 26, 2023
Merged
@jukzi jukzi mentioned this issue Aug 1, 2023
Merged
@zelenyhleb zelenyhleb mentioned this issue Aug 3, 2023
Merged
This was referenced Sep 11, 2023
Merged
Merged
@iloveeclipse
Copy link
Member

Fails often in github actions:
https://github.com/eclipse-platform/eclipse.platform.ui/runs/16899215954

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.fail(Assert.java:96)
	at org.eclipse.ui.genericeditor.tests.HoverTest.getHoverShell(HoverTest.java:175)
	at org.eclipse.ui.genericeditor.tests.HoverTest.testEnabledWhenHover(HoverTest.java:90)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

FocusControl: 
  ToolBar {} [layout=null]
    CTabFolder {} [layout=org.eclipse.swt.custom.CTabFolderLayout@738153d8]
      Composite {} [layout=org.eclipse.e4.ui.workbench.renderers.swt.SashLayout@1a3272e0]
        Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
          Composite {} [layout=StackLayout {topControl=Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]}]
            Composite {} [layout=org.eclipse.e4.ui.workbench.renderers.swt.SashLayout@7bc3c59f]
              Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
                Shell {data - org.eclipse.ui.genericeditor.tests.HoverTest1695059443047/enabledWhen.txt} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@6db2a260]
Shells: 
  inactive, invisible: Shell {PartRenderingEngine's limbo} [layout=null] @ Rectangle {0, 10000, 800, 640}
  active, visible: Shell {data - org.eclipse.ui.genericeditor.tests.HoverTest1695059443047/enabledWhen.txt} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@6db2a260] @ Rectangle {0, 0, 1024, 768}
  inactive, invisible: Shell {} [layout=null] @ Rectangle {0, 0, 800, 640}
Client area: Rectangle {0, 0, 1280, 1024}
Cursor location: Point {306, 102}
CursorControl: 
  StyledText {} [layout=null]
    Canvas {} [layout=org.eclipse.jface.text.source.SourceViewer$RulerLayout@56b66cc6]
      Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
        Composite {} [layout=StackLayout {topControl=Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]}]
          Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
            ContributedPartRenderer$1 {} [layout=FillLayout {type=SWT.VERTICAL}]
              CTabFolder {} [layout=org.eclipse.swt.custom.CTabFolderLayout@6f076c53]
                Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
                  Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
                    Composite {} [layout=org.eclipse.e4.ui.workbench.renderers.swt.SashLayout@1a3272e0]
                      Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
                        Composite {} [layout=StackLayout {topControl=Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]}]
                          Composite {} [layout=org.eclipse.e4.ui.workbench.renderers.swt.SashLayout@7bc3c59f]
                            Composite {} [layout=FillLayout {type=SWT.HORIZONTAL}]
                              Shell {data - org.eclipse.ui.genericeditor.tests.HoverTest1695059443047/enabledWhen.txt} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@6db2a260]
Display @ Rectangle {0, 0, 1280, 1024}

@iloveeclipse iloveeclipse mentioned this issue Sep 19, 2023
Merged
@HeikoKlare HeikoKlare mentioned this issue Oct 5, 2023
Merged
This was referenced Oct 11, 2023
Merged
Merged
@jukzi jukzi mentioned this issue Oct 23, 2023
Merged
@marcushoepfner marcushoepfner mentioned this issue Oct 25, 2023
Merged
@jukzi jukzi mentioned this issue Oct 27, 2023
Merged
@jukzi jukzi added the test junit test related things label Nov 28, 2023
@fedejeanne fedejeanne added the help wanted Extra attention is needed label Dec 8, 2023
@jukzi jukzi mentioned this issue Apr 16, 2024
Open
@HeikoKlare HeikoKlare mentioned this issue Apr 22, 2024
Merged
@fedejeanne fedejeanne mentioned this issue May 13, 2024
Merged
@HeikoKlare HeikoKlare mentioned this issue Jun 6, 2024
Merged
@BeckerWdf BeckerWdf mentioned this issue Jun 7, 2024
Merged
@HeikoKlare HeikoKlare mentioned this issue Jul 5, 2024
Merged
This was referenced Jul 8, 2024
Merged
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 16, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
e9f9f2f 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
@HeikoKlare HeikoKlare mentioned this issue Jul 16, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 16, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
82aec9d 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 16, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
51fa1a8 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
@Wittmaxi Wittmaxi mentioned this issue Jul 16, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 16, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
d00be4b 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
@marcushoepfner marcushoepfner mentioned this issue Jul 22, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 23, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
058c185 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
@HeikoKlare HeikoKlare mentioned this issue Aug 6, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Aug 7, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
4183c63 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
This was referenced Aug 13, 2024
Merged
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Aug 19, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
972bda5 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Sep 4, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
414767f 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
@BeckerWdf BeckerWdf mentioned this issue Oct 17, 2024
Merged
@HeikoKlare HeikoKlare mentioned this issue Oct 29, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 7, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
854004e 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 7, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
49db425 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 8, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
fedc0fd 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 8, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest eclipse-platf…
a97b1da 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
HeikoKlare added a commit that referenced this issue Nov 8, 2024
@HeikoKlare
Improve and add assertions for random failing HoverTest #926 #1808
2c07aa7 
This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
#926
Contributes to
#1808
@jukzi jukzi mentioned this issue Dec 2, 2024
Merged
mai-tran-03 pushed a commit to mai-tran-03/eclipse.platform.ui that referenced this issue Dec 10, 2024
@HeikoKlare @mai-tran-03
Improve and add assertions for random failing HoverTest eclipse-platf…
7977ca6 
…orm#926 eclipse-platform#1808

This contributes to fixing the randomly failing HoverTests:
- Removes unnecessary focus enforcing: The code checks for the text
editor having focus and afterwards uses different methods to force focus
to the widget's shell again. This is unnecessary and is only prone to
introduce further problems.
- Introduces further assertions: in order to better locate the cause of
the failing tests, assertions are added for the conditions, on which the
execution waits, to be actually fulfilled.
- Adds a retry functionality for simulating the hover event.

Contributes to
eclipse-platform#926
Contributes to
eclipse-platform#1808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test junit test related things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iloveeclipse @fedejeanne @jukzi