Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up: Add final modifier to private fields #1178

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Clean Up: Add final modifier to private fields #1178

merged 2 commits into from
Oct 23, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Sep 29, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023 •
edited
Loading

Test Results

     900 files  ±0       900 suites  ±0   1h 53m 9s ⏱️ +37s
  7 450 tests ±0    7 292 ✔️  - 2  156 💤 ±0  2 ❌ +2 
23 499 runs  ±0  22 979 ✔️  - 2  518 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 24f8d7e. ± Comparison against base commit c1f268d.

♻️ This comment has been updated with latest results.

HeikoKlare
HeikoKlare reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have these variables declared as final. If I see correctly, only some versions need to be bumped and then this PR can be merged?

@jukzi jukzi force-pushed the final branch 3 times, most recently from 07758a5 to 5042ea2 Compare October 23, 2023 11:07
@jukzi
Copy link
Contributor Author

jukzi commented Oct 23, 2023

ignoring random failing HoverTest, UIEditWorkingSetWizardAuto

#926
#275

@jukzi jukzi merged commit 062079d into eclipse-platform:master Oct 23, 2023
@jukzi jukzi deleted the final branch October 23, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jukzi @HeikoKlare @EcljpseB0T