Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store workbench preference dialog bounds. #964

Conversation

marcushoepfner
Copy link
Contributor

Issue #949

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Test Results

     900 files  +       1       900 suites  +1   1h 51m 31s ⏱️ + 20m 40s
  7 455 tests ±       0    7 297 ✔️ ±       0  156 💤 ±    0  2 ±0 
23 514 runs  +1 563  22 994 ✔️ +1 440  518 💤 +123  2 ±0 

For more details on these failures, see this check.

Results for commit 7f888a0. ± Comparison against base commit 5fd4ad8.

♻️ This comment has been updated with latest results.

@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch 3 times, most recently from 1819c68 to d7723ed Compare September 12, 2023 08:55
@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch 3 times, most recently from 239ed4f to d42fc14 Compare September 25, 2023 07:33
@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch 2 times, most recently from 52cd2c7 to 057edb7 Compare October 17, 2023 07:47
@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch 2 times, most recently from 652b723 to a15406c Compare October 25, 2023 06:33
@marcushoepfner
Copy link
Contributor Author

Failing test relates to #926

@marcushoepfner
Copy link
Contributor Author

Added some reviewers. Feel free to remove yourself if you don't feel confident/have time.
Thanks

@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch from a15406c to df5c302 Compare October 31, 2023 14:00
@marcushoepfner marcushoepfner force-pushed the store_preference_dialog_bounds branch from df5c302 to 7f888a0 Compare November 6, 2023 09:28
@marcushoepfner
Copy link
Contributor Author

For failing HoverTest and ProgressContantsTest issues exist.
They are not caused by this PR.
I'm going to merge.

@marcushoepfner marcushoepfner merged commit 4cd5bda into eclipse-platform:master Nov 6, 2023
@marcushoepfner marcushoepfner deleted the store_preference_dialog_bounds branch November 6, 2023 11:33
marcushoepfner added a commit to marcushoepfner/eclipse.platform.ui that referenced this pull request Dec 7, 2023
marcushoepfner added a commit to marcushoepfner/eclipse.platform.ui that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants