FNS changes on top of 5.2.x #2098

jonfung-dydx · 2024-08-15T23:51:15Z

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
Manually add any of the following labels: refactor, chore, bug.

…aker order as first class order status field. (#1996)

…er (#1776)

Co-authored-by: Jonathan Fung <[email protected]>

…#2022)

… on flush (#2068)

Co-authored-by: Jonathan Fung <[email protected]> Co-authored-by: Jonathan Fung <[email protected]>

coderabbitai · 2024-08-15T23:51:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

protocol/streaming/ws/websocket_server.go

+
+		subaccountIds = append(subaccountIds, &satypes.SubaccountId{
+			Owner:  parts[0],
+			Number: uint32(number),


protocol/streaming/ws/websocket_server.go

+		if err != nil {
+			return nil, fmt.Errorf("invalid clobPairId: %s", idStr)
+		}
+		clobPairIds = append(clobPairIds, uint32(id))


Co-authored-by: jayy04 <[email protected]>

… (backport #2124) (#2125) Co-authored-by: jayy04 <[email protected]>

This reverts commit 64faba3.

dydxwill and others added 23 commits August 15, 2024 16:17

[CT-964] Send deleveraging events in grpc stream (#1903)

b232282

gRPC streaming clean up (#1906)

d113cb7

Post only order breaks out of matching loop + Add post only crosses m…

41c4057

…aker order as first class order status field. (#1996)

GPRC Streaming change default flag options, break upon connection ord…

ec44fce

…er (#1776)

Full Node Status taker order status protos (#2003)

987134d

Fix proto formatting (#2020)

f627b04

FNS protos - add taker order in stream update oneof (#2021)

5bf5e3d

add subaccount support for grpc stream (#1992)

566282b

Fix orders issue for deleveraging events (#1958)

460454f

Co-authored-by: Jonathan Fung <[email protected]>

Restructure FNS global cache to be list (#2036)

73d39d3

Bump grpc stream flag default values (#2051)

a7d0270

Bump grpc stream flag default values (#2051)

8b6c3d2

[Full node streaming] emit taker order status at end of matching loop (…

a4bed83

…#2022)

fix merge conflict and metric emissions (#2065)

c23eb39

Full node streaming batch size reset to 2000, properly zero out cache…

3da874b

… on flush (#2068)

FNS subaccount implementation (#2059)

3f76b54

[CT-1050] DeliverTx state change reset for subaccount updates (#2063)

6b8e014

Co-authored-by: Jonathan Fung <[email protected]> Co-authored-by: Jonathan Fung <[email protected]>

Fix snapshot bool (#2078)

5297fbd

Full Node Streaming Recurring snapshots (#2079)

0fa54f4

Remove todo (#2087)

e06739d

Add websocket support to full node streaming (#1908)

66e7d98

Full Node Streaming default port 9092 (#2092)

b960fe4

[CT-1103] FNS subaccount WS support (#2088)

1ee13ed

github-actions bot added indexer protocol proto labels Aug 15, 2024

github-advanced-security bot found potential problems Aug 15, 2024

View reviewed changes

dydxwill and others added 2 commits August 23, 2024 09:44

fix merge conflicts (#2115)

06f1012

modify gh wf

2e62083

mergify bot and others added 3 commits August 26, 2024 06:29

paginate liquidation daemon response (backport #2118) (#2119)

8a0261f

Co-authored-by: jayy04 <[email protected]>

add telemetry and logs for liquidation daemon (backport #2122) (#2123)

06cba16

Co-authored-by: jayy04 <[email protected]>

skip liquidation task loop if last committed block height is the same…

b839bb3

… (backport #2124) (#2125) Co-authored-by: jayy04 <[email protected]>

dydxwill marked this pull request as ready for review August 26, 2024 16:58

dydxwill and others added 3 commits August 26, 2024 07:00

revert gh wf

08be416

Full node streaming remove minimum for snapshot interval flag (#2138)

086e07c

Support empty params for websocket endpoint (#2111)

a2bf192

jayy04 approved these changes Aug 26, 2024

View reviewed changes

dydxwill merged commit 64faba3 into release/protocol/v5.2.x Aug 26, 2024
39 of 41 checks passed

dydxwill deleted the jonfung/5.2.x-fns branch August 26, 2024 20:24

dydxwill restored the jonfung/5.2.x-fns branch September 9, 2024 20:44

jonfung-dydx added a commit that referenced this pull request Sep 25, 2024

Revert "FNS changes on top of 5.2.x (#2098)"

28b2fae

This reverts commit 64faba3.

jonfung-dydx added a commit that referenced this pull request Sep 25, 2024

Revert "FNS changes on top of 5.2.x (#2098)"

8977627

This reverts commit 64faba3.

ttl33 mentioned this pull request Sep 25, 2024

Revert "FNS changes on top of 5.2.x #2098" #2349

Merged

6 tasks

jonfung-dydx added a commit that referenced this pull request Sep 25, 2024

Revert "FNS changes on top of 5.2.x (#2098)"

5e24954

This reverts commit 64faba3.

jonfung-dydx added a commit that referenced this pull request Sep 25, 2024

Revert "FNS changes on top of 5.2.x #2098" (#2349)

8843936

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FNS changes on top of 5.2.x #2098

FNS changes on top of 5.2.x #2098

jonfung-dydx commented Aug 15, 2024

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

FNS changes on top of 5.2.x #2098

FNS changes on top of 5.2.x #2098

Conversation

jonfung-dydx commented Aug 15, 2024

Changelist

Test Plan

Author/Reviewer Checklist

coderabbitai bot commented Aug 15, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)