fix merge conflict and metric emissions

[jonfung-dydx]

• Fix merge conflict
• AddUpdatesToCache records raw number of StreamUpdates added in cache

Summary by CodeRabbit

• Improvements
  • Streamlined the process of adding updates to the cache by removing the need for an explicit count, enhancing usability and reducing potential errors.
  • Simplified method calls in the Full Node Streaming Manager, improving code clarity and maintenance.

[coderabbitai]

Walkthrough

The updates to the FullNodeStreamingManagerImpl class streamline the handling of orderbook updates by removing the numUpdatesToAdd parameter from method calls. This change simplifies the code by allowing the method to determine the number of updates internally, reducing potential errors and enhancing clarity while maintaining existing functionality.

Changes

Files	Change Summary
protocol/streaming/full_node_streaming_manager.go	Removed the numUpdatesToAdd parameter from AddUpdatesToCache method calls and its signature, simplifying update handling.

Poem

In the code where rabbits play,
Updates hop in a cleaner way.
With fewer numbers to keep in line,
Our code runs smooth and looks just fine.
Let's celebrate this joyful cheer,
As clarity brings the future near! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d5dfa5 and d340113.

Files selected for processing (1)

• protocol/streaming/full_node_streaming_manager.go (3 hunks)

Additional comments not posted (5)

protocol/streaming/full_node_streaming_manager.go (5)

353-353: LGTM: Simplified method call.

The removal of the numUpdatesToAdd parameter simplifies the method call without altering the functionality.

---

396-396: LGTM: Simplified method call.

The removal of the numUpdatesToAdd parameter simplifies the method call without altering the functionality.

---

414-423: LGTM: Simplified method call.

The removal of the numUpdatesToAdd parameter simplifies the method call without altering the functionality.

---

Line range hint 427-448: LGTM: Enhanced clarity by removing parameter.

The removal of the numUpdatesToAdd parameter enhances clarity and reduces potential errors related to mismatched counts.

---

Line range hint 472-523: No changes were made to this method.