Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove todo #2087

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove todo #2087

merged 1 commit into from
Aug 14, 2024

Conversation

dydxwill
Copy link
Contributor

@dydxwill dydxwill commented Aug 14, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Chores
    • Removed a comment related to a future enhancement for subaccount updates, reflecting a strategic shift without affecting current functionality.

Copy link
Contributor

coderabbitai bot commented Aug 14, 2024

Walkthrough

The recent change in the FullNodeStreamingManagerImpl class involves the removal of a comment in the SendSubaccountUpdates function. This comment previously indicated a planned enhancement for aggregating subaccount updates by their IDs. Although the function's implementation remains unchanged, the deletion of the comment reflects a decision to shift focus away from this feature at this time.

Changes

Files Change Summary
protocol/streaming/full_node_streaming_manager.go Removed a comment in SendSubaccountUpdates regarding future aggregation of subaccount updates. No functional changes were made.

Poem

In the meadow where bunnies play,
A comment hopped away today.
No more talk of updates to queue,
Just the code, fresh and new!
We’ll leap and bound, no worries in sight,
For decisions made, feel just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14fffa4 and 9a2be31.

Files selected for processing (1)
  • protocol/streaming/full_node_streaming_manager.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • protocol/streaming/full_node_streaming_manager.go

@dydxwill dydxwill merged commit 580b29c into main Aug 14, 2024
17 checks passed
@dydxwill dydxwill deleted the wl/rm-todo branch August 14, 2024 15:51
jonfung-dydx pushed a commit that referenced this pull request Aug 15, 2024
jonfung-dydx pushed a commit that referenced this pull request Sep 17, 2024
jonfung-dydx pushed a commit that referenced this pull request Sep 26, 2024
jonfung-dydx pushed a commit that referenced this pull request Oct 4, 2024
jonfung-dydx pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants