Update develop-ref after #2094 #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* first pass at documentation, config, and python scripts * 2nd addition of files to use case * updated config file for dir path * Update use_case_groups.json * Removed unused config options
…or METdataio (renamed from METdatadb) to use in automated tests
* changing from 2nd to 3rd person and fixing some spacing #770 * missed we and corrected #770 * typos, spacing etc #770 * spelling, italics and bolding #770 * removing you changing to 3rd person #770 * changing to 3rd person #770 * 3rd person already done. Fixing formatting, typos etc. #770 * 3rd person already done. Fixing formatting #770 * changing to 3rd person, fixing typos, spacing, etc. #770 * changing to 3rd person, fixing typos, grammar and punctuation. #770 * google doc corrections. #770 * clean up #770 * removing | #770 * typo #770 * Fixing TOC and coding block #770 * fixing note #770 * one 3rd person fix. Updating bolding and italics for file names and directories #770 * Modified Python Code Analyis Tools * Modified Python Code Analyis Tools * Removed link for PROCESS_LIST. If we can't have an internal link, we do not want one in this case. * fixing space #770 * fixing conflict #2 #770 * fixing typos #770 * fixing typos #2 #770 * directory formatting #2 #770 * Changed sub process to subprocess * Modified usage of user because this text is for developers. Made other minor changes. * first attempt at grammar, bolding, italics and period clean up #770 * under 79 characters #770 * changing to 3rd person #770 * fixing typos #770 * 3rd person and typos #770 * fixing formatting #770 * typo cleanup #770 * more typo cleanup #770 * adding periods to most bullet lists #770 * adding periods to most bullet lists #770 * changing web address to italics instead of bold, not linking because it is an example. * creating links attempt. * creating links attempt #2. * creating links attempt #3. * fixing typo for add_use_categories * removing warning block per George M. * changing sentence * no screenshots to be added * adding note box * fixing bolding * Made some minor tweaks Co-authored-by: Julie Prestopnik <[email protected]>
* per #685, added custom pytest markers for many tests so we can run groups of tests in automation to speed things up. removed unused imports from tests and removed parenthesis from assert statements when they are not needed * per #685, change logic to check if test category is not equal to 'pytest' to does not start with 'pytest' to allow groups of pytests * per #685, run pytests with markers to subset tests into groups * fixed check if string starts with pytests * added missing pytest marker name * added logic to support running all pytests that do not match a given marker with the 'not <marker>' syntax * change pytest group to wrapper because the test expects another test to have run prior to running * fix 'not' logic by adding quotation marks around value * another approach to fixing not functionality for tests * added util marker to more tests * fixed typo in not logic * added util marker to more tests again * fixed logic to split string * marked rest of util tests with util marker * fixed another typo in string splitting logic * tested change that should properly split strings * moved wrapper tests into wrapper directory * changed marker for plotting tests * added plotting marker * improved logic for removing underscore after 'not' and around 'or' to specify more complex marker strings * test running group of 3 markers * fixed path the broke when test file was moved into a lower directory * Changed StatAnalysis tests to use plotting marker because some of the tests involve plotting but the other StatAnalysis tests produce output that are used in the plotting tests * changed some tests from marker 'wrapper' to 'wrapper_a' to split up some of these tests into separate runs * test to see if running pytests in single job but split into groups by marker will improve the timing enough * fixed typos in new logic * removed code that is no longer needed (added comment in issue #685 if this logic is desired in the future) * per #685, divided pytests into smaller groups * added a test that will fail to test that the entire pytest job will fail as expected * add error message if any pytests failed to help reviewer search for failed tests * removed failing test after confirming that entire pytest job properly reports an error if any test fails * turn on single use case group to make sure logic to build matrix of test jobs to run still works as expected * turn off use case after confirming tests were created properly * added documentation to contributor's guide to describe changes to unit test logic * added note about adding new pytest markers
* Per #1402, added additional comments to config file including links to documentation. Added old format version of config file that contain many comments with the _DIR/_TEMPLATE variables grouped together for comparison * rearrange variables and added link to user's guide * updated comment to note that variables in the section are optional * added URL for use case documentation * per #1402, rearrange and clean up config file * added missing config variables from CyclonePlotter to glossary and wrappers doc pages * per #1402, clean up use case conf files, ci-run-all-diff * per #1402, clean up Point2Grid conf file * per #1402, clean up rest of met_tool_wrapper use case conf files, ci-run-all-diff * removed conf file that is no longer needed
…ata_assimilation
…use case currently is only available in develop, it will eventually be in latest when the next release is created
* per #1694, moved 4 use cases from s2s to s2s_mjo, updated paths accordingly, and turned on all s2s use cases to test that they all run successfully after the changes * per #1694, fixed paths to s2s_mjo conf files * updated documentation for use cases that were moved from s2s to s2s_mjo * attempt to free up unused disk space in GHA runner environment * moved 4 s2s use cases into s2s_mid_lat * added new model application categories to contrib guide for adding new use cases * per #947, changed convection_allowing_models use cases to short_range * changed which use case tests run to the ones that are failing and added other METdbLoad use case to see if that fails as well * test to determine which files are preventing MySQL database from being created properly * test 2 to determine which files are preventing MySQL database from being created properly * test 3 to see if removing these files is not the cause of the METdbLoad failure * updated references to METdatadb to METdataio since the repository was renamed * fixed typo * changed path to sql file needed to create database because it was moved from METviewer to METdataio * fixed path to sql file that was moved from METviewer to METdataio * removed temporary fix because metdataio conda env was created in the dtcenter/metplus-envs:metdataio Docker image * added note to update path when METviewer Dockerfile changes to reflect METdatadb rename to METdataio, ci-skip-unit-tests * fixed path to METdataio repo * add back commands to free up disk space because issue with METdbLoad use case was likely not related, ci-skip-unit-tests * run all tests with ci-run-all-diff * remove use case group added for testing, ci-skip-all * changed exit code for diff tests to 2 so it is easier to see if a use case test job failed due to an actual failure or due to differences in the output * changed grouping of s2s mid lat use cases to original grouping to prevent warning that artifact contains more than 10,000 files. The 2 WeatherRegime use cases produce a lot of output files, so splitting them up should resolve this warning * per #1694, changed all references to convection allowing models to short range in the Verification Datasets section of the documentation * changed URLs to develop version of documentation to a URL relative to the current version of the documentation to match the quick search links from the METplus User's Guide * per #947, changed references to convection_allowing_model (without the s) to short_range that were missed * updated use case test scripts to rename convection_allowing_models to short_range and added note to alert developers that the list of use cases in the script is not maintained and therefore not complete
…and s2s_mjo. ci-run-all-diff
…mpty string. Previously a False default value was logged as set to empty string
…a default value of False
…or this wrapper is optional and different behavior will be executed if no config file is set
…or this wrapper is optional and different behavior will be executed if no config file is set
…will contain use case category to more easily see which case was run
…r-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062)
* updated version number * added release notes * Update docs/Users_Guide/release-notes.rst Co-authored-by: John Halley Gotway <[email protected]> --------- Co-authored-by: John Halley Gotway <[email protected]>
… used if the pre-processing steps are needed
* test dropdowns * Update release-notes.rst Attempting to resolve WARNING * testing dropdowns * adding dropdown menus * testing dropdown remove from warning section * dropdown testing * dropdown menu tests * dropdown menus after the warnings section, the dropdown menu only has one space instead of the normal 2 spaces. If it has 2 spaces, it gets sucked into the warning section. * spaces with warning * no spaces for warning * Update release-notes.rst warning note has to be indented 1 space. Originally it was no spaces but then all of the dropdown menus end up in the warning message. If it's 2 spaces, as is normal, then the warning is indented, which is unnecessary. 1 space is slightly indented and keeps the dropdown menus separate. --------- Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: George McCabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New use case - MODE Multivariate
Created by @georgemccabe