-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature #1402 config cleanup - met_tool_wrapper #1690
Conversation
…o documentation. Added old format version of config file that contain many comments with the _DIR/_TEMPLATE variables grouped together for comparison
parm/use_cases/met_tool_wrapper/GridStat/GridStat_comments.conf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a few of the automated testings failed: I'm not too concerned with the model application ones, since I believe that's related to a separate reorganization, but the met_tool_wrapper group 30-58 failed. It has some debug messages of "removing symbolic link", but I think the actual error is from the METdbLoad section. Can this be explained? If so, I have reviewed this PR and didn't find anything moved or printed in error so it's ready to be merged.
@j-opatz, Yes, the failures in the tests are due to the s2s use cases using up all of the disk space. It appears to cause random other groups to fail because I have rerun them before and they ran fine. The met_tool_wrapper failure is due to the sql definition fine used to set up METviewer was moved from that repo into METdatadb (now METdataio). Pull request #1697 will resolve those issues. |
Another PR will follow for the model_applications conf files. I want to confirm that everything is good here before moving onto those use cases.
Pull Request Testing
Ran all use cases and diff tests
Review changes for consistency, copy/paste mistakes, etc.
Confirm format used for all conf files is acceptable
Ensure all automated tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 7/13/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes