Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all references from Convection Allowing Models to Short Range #947

Closed
21 tasks
georgemccabe opened this issue Jun 9, 2021 · 1 comment · Fixed by #1697
Closed
21 tasks

Change all references from Convection Allowing Models to Short Range #947

georgemccabe opened this issue Jun 9, 2021 · 1 comment · Fixed by #1697
Assignees
@georgemccabe @j-opatz
Labels
component: CI/CD Continuous integration and deployment issues component: code cleanup Code cleanup and maintenance issue component: documentation Documentation issue component: testing Software testing issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METplus-5.0.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jun 9, 2021 •
edited by TaraJensen
Loading

Change parm/use_cases/model_applications/convection_allowing_models to parm/use_cases/model_applications/short_range and update all other references.

Describe the Enhancement

This will involve many changes including use case paths, documentation, testing scripts, etc.

Time Estimate

~1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2702691 2792541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added the type: enhancement Improve something that it is currently doing label Jun 9, 2021
@georgemccabe georgemccabe self-assigned this Jun 9, 2021
@georgemccabe georgemccabe added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: CI/CD Continuous integration and deployment issues component: code cleanup Code cleanup and maintenance issue component: documentation Documentation issue component: testing Software testing issue component: use case configuration priority: high High Priority requestor: METplus Team METplus Development Team labels Jun 9, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Jun 9, 2021
@georgemccabe georgemccabe added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Aug 25, 2021
@georgemccabe georgemccabe removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Feb 8, 2022
@georgemccabe georgemccabe changed the title Change all references to Convection Allowing Models to Short Range Change all references from Convection Allowing Models to Short Range May 24, 2022
@georgemccabe georgemccabe moved this from Todo to In Progress in METplus-Wrappers-5.0.0-beta2 (8/3/22) Jul 13, 2022
georgemccabe added a commit that referenced this issue Jul 13, 2022
@georgemccabe
per #947, changed convection_allowing_models use cases to short_range
f37dfaf
@georgemccabe
Copy link
Collaborator Author

I am going to complete this task as part of the work for #1694

@georgemccabe georgemccabe mentioned this issue Jul 14, 2022
Merged
14 tasks
@georgemccabe georgemccabe linked a pull request Jul 14, 2022 that will close this issue
Feature 1694 s2s subgroups #1697
Merged
14 tasks
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jul 14, 2022
@georgemccabe georgemccabe moved this from In Progress to Review in METplus-Wrappers-5.0.0-beta2 (8/3/22) Jul 14, 2022
georgemccabe added a commit that referenced this issue Jul 18, 2022
@georgemccabe
per #947, changed references to convection_allowing_model (without th…
36a6d06 
…e s) to short_range that were missed
georgemccabe added a commit that referenced this issue Jul 18, 2022
@georgemccabe
Feature 1694 s2s subgroups (#1697)
a20c0bb 
* per #1694, moved 4 use cases from s2s to s2s_mjo, updated paths accordingly, and turned on all s2s use cases to test that they all run successfully after the changes

* per #1694, fixed paths to s2s_mjo conf files

* updated documentation for use cases that were moved from s2s to s2s_mjo

* attempt to free up unused disk space in GHA runner environment

* moved 4 s2s use cases into s2s_mid_lat

* added new model application categories to contrib guide for adding new use cases

* per #947, changed convection_allowing_models use cases to short_range

* changed which use case tests run to the ones that are failing and added other METdbLoad use case to see if that fails as well

* test to determine which files are preventing MySQL database from being created properly

* test 2 to determine which files are preventing MySQL database from being created properly

* test 3 to see if removing these files is not the cause of the METdbLoad failure

* updated references to METdatadb to METdataio since the repository was renamed

* fixed typo

* changed path to sql file needed to create database because it was moved from METviewer to METdataio

* fixed path to sql file that was moved from METviewer to METdataio

* removed temporary fix because metdataio conda env was created in the dtcenter/metplus-envs:metdataio Docker image

* added note to update path when METviewer Dockerfile changes to reflect METdatadb rename to METdataio, ci-skip-unit-tests

* fixed path to METdataio repo

* add back commands to free up disk space because issue with METdbLoad use case was likely not related, ci-skip-unit-tests

* run all tests with ci-run-all-diff

* remove use case group added for testing, ci-skip-all

* changed exit code for diff tests to 2 so it is easier to see if a use case test job failed due to an actual failure or due to differences in the output

* changed grouping of s2s mid lat use cases to original grouping to prevent warning that artifact contains more than 10,000 files. The 2 WeatherRegime use cases produce a lot of output files, so splitting them up should resolve this warning

* per #1694, changed all references to convection allowing models to short range in the Verification Datasets section of the documentation

* changed URLs to develop version of documentation to a URL relative to the current version of the documentation to match the quick search links from the METplus User's Guide

* per #947, changed references to convection_allowing_model (without the s) to short_range that were missed

* updated use case test scripts to rename convection_allowing_models to short_range and added note to alert developers that the list of use cases in the script is not maintained and therefore not complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

@j-opatz j-opatz

Labels
component: CI/CD Continuous integration and deployment issues component: code cleanup Code cleanup and maintenance issue component: documentation Documentation issue component: testing Software testing issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
No open projects
METplus-Wrappers-5.0.0-beta2 (8/3/22)
Status: Done
Milestone
METplus-5.0.0
Development

Successfully merging a pull request may close this issue.

Feature 1694 s2s subgroups dtcenter/METplus
4 participants
@jprestop @TaraJensen @georgemccabe @j-opatz