Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature_770_3rd_person #1685

Merged
merged 55 commits into from
Jul 14, 2022
Merged

Feature_770_3rd_person #1685

merged 55 commits into from
Jul 14, 2022

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Jul 1, 2022

Pull Request Testing

  • Describe testing already performed for these changes:

    Changed 2nd person (you) to 3rd person (one or restructured the sentence to not refer to a person.)
    There were other grammar changes, spelling, bolding, keeping lines under 79 characters when possible,
    updating links, typo fixes and updates to code blocks along the way.
    Lisa created METplus Contributors Guide grammar check 2022 to reiterate back and forth with Julie P and George when there were questions about what should be changed or not.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please read through the documentation changes to make sure that the changes improve the clarity and ease of use for the reader. https://metplus.readthedocs.io/en/feature_770_3rd_person

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
    This runs smoothly through ReadTheDocs no errors or warnings occur.

  • Do these changes include sufficient testing updates? [No]. No testing needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [7/15/22]. This date was chosen randomly. It's okay to change the date. It's best to add this to develop before more changes occur.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table. This doesn't apply.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s).
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

lisagoodrich and others added 30 commits April 4, 2022 10:44
@lisagoodrich lisagoodrich added the component: documentation Documentation issue label Jul 1, 2022
@lisagoodrich lisagoodrich added this to the METplus-5.0.0 milestone Jul 1, 2022
@lisagoodrich lisagoodrich requested a review from jprestop July 1, 2022 16:55
@lisagoodrich lisagoodrich linked an issue Jul 1, 2022 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this task, @lisagoodrich! I have read through the changes and made some minor tweaks. I approve this pull request.

@jprestop jprestop merged commit f79c809 into develop Jul 14, 2022
@jprestop jprestop deleted the feature_770_3rd_person branch July 14, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Change perspective of Contributor's Guide chapters to 3rd person
2 participants