-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature_770_3rd_person #1685
Merged
Merged
Feature_770_3rd_person #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do not want one in this case.
…it is an example.
21 tasks
jprestop
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this task, @lisagoodrich! I have read through the changes and made some minor tweaks. I approve this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Changed 2nd person (you) to 3rd person (one or restructured the sentence to not refer to a person.)
There were other grammar changes, spelling, bolding, keeping lines under 79 characters when possible,
updating links, typo fixes and updates to code blocks along the way.
Lisa created METplus Contributors Guide grammar check 2022 to reiterate back and forth with Julie P and George when there were questions about what should be changed or not.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please read through the documentation changes to make sure that the changes improve the clarity and ease of use for the reader. https://metplus.readthedocs.io/en/feature_770_3rd_person
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
This runs smoothly through ReadTheDocs no errors or warnings occur.
Do these changes include sufficient testing updates? [No]. No testing needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [7/15/22]. This date was chosen randomly. It's okay to change the date. It's best to add this to develop before more changes occur.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s).
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes