Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove mkdirp dependency #1549

Merged
merged 1 commit into from
Aug 25, 2024
Merged

perf: remove mkdirp dependency #1549

merged 1 commit into from
Aug 25, 2024

Conversation

benmccann
Copy link
Contributor

No description provided.

dsherret
dsherret approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret changed the title chore: remove mkdirp dependency perf: remove mkdirp dependency Jun 26, 2024
dsherret
dsherret requested changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have introduced a regression. See CI output. We'll just have to update this code to not throw for existing directories.

@benmccann
Copy link
Contributor Author

sorry, I can't figure out how to run the project locally. I've never used Deno before and am not familiar with what's happening in the build process. I noticed an error in the code and updated it, so hopefully that will get the tests passing. If not, I may need a little help with this one

@dsherret
Copy link
Owner

I think it should just be to run npm install in the root, then cd packages/common, then npm run test

@benmccann
Copy link
Contributor Author

ah, cool. thanks. that worked! I was trying to build it from the root first, which wasn't working at all

@benmccann benmccann requested a review from dsherret June 26, 2024 21:15
@benmccann
Copy link
Contributor Author

@dsherret would you be able to give this PR another peek now that the CI is passing? thanks!

dsherret
dsherret approved these changes Aug 25, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 69f674d into dsherret:latest Aug 25, 2024
2 checks passed
@dsherret dsherret mentioned this pull request Aug 25, 2024
Closed
@benmccann benmccann deleted the rm-mkdirp branch August 25, 2024 19:48
@benmccann benmccann mentioned this pull request Aug 25, 2024
Merged
@souporserious souporserious mentioned this pull request Jan 18, 2025
Closed
renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 26, 2025
@renovate
chore(deps): update dependency ts-morph to v25
f21addb 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 28, 2025
@renovate
chore(deps): update dependency ts-morph to v25
6dd66ca 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 1, 2025
@renovate
chore(deps): update dependency ts-morph to v25
15cb92b 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 2, 2025
@renovate
chore(deps): update dependency ts-morph to v25
e5d3560 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 5, 2025
@renovate
chore(deps): update dependency ts-morph to v25
c07679d 
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccann @dsherret