perf: remove mkdirp dependency (#1549)

dsherret · Aug 25, 2024 · 69f674d · 69f674d
1 parent 5e208c5
commit 69f674d
Show file tree

Hide file tree

Showing 5 changed files with 170 additions and 192 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/common/package.json b/packages/common/package.json
@@ -21,7 +21,6 @@
   "dependencies": {
     "fast-glob": "^3.3.2",
     "minimatch": "^9.0.4",
-    "mkdirp": "^3.0.1",
     "path-browserify": "^1.0.1"
   },
   "devDependencies": {

diff --git a/packages/common/scripts/buildDeno.ts b/packages/common/scripts/buildDeno.ts
@@ -23,9 +23,9 @@ commonFile.getFunctionOrThrow("isNodeJs").remove();
 commonFile.getImportDeclarationOrThrow("path").remove();
 commonFile.getImportDeclarationOrThrow("minimatch").remove();
 commonFile.getImportDeclarationOrThrow("fast-glob").remove();
-commonFile.getImportDeclarationOrThrow("mkdirp").remove();
 commonFile.getImportDeclarationOrThrow("os").remove();
 commonFile.getImportDeclarationOrThrow("fs").remove();
+commonFile.getImportDeclarationOrThrow("fs/promises").remove();
 commonFile.getVariableDeclarationOrThrow("path$1").remove();
 
 const runtimeFileDestinationPath = `${folderPath}/DenoRuntime.ts`;

diff --git a/packages/common/src/data/libFiles.ts b/packages/common/src/data/libFiles.ts
diff --git a/packages/common/src/runtimes/NodeRuntime.ts b/packages/common/src/runtimes/NodeRuntime.ts
@@ -1,7 +1,7 @@
 import fastGlob from "fast-glob";
 import * as fs from "fs";
+import * as fsp from "fs/promises";
 import * as minimatch from "minimatch";
-import * as mkdirp from "mkdirp";
 import * as os from "os";
 import * as path from "path";
 import { Runtime, RuntimeFileInfo, RuntimeFileSystem, RuntimePath } from "./Runtime";
@@ -97,11 +97,11 @@ class NodeRuntimeFileSystem implements RuntimeFileSystem {
   }
 
   async mkdir(dirPath: string) {
-    await mkdirp.mkdirp(dirPath);
+    await fsp.mkdir(dirPath, { recursive: true });
   }
 
   mkdirSync(dirPath: string) {
-    mkdirp.sync(dirPath);
+    fs.mkdirSync(dirPath, { recursive: true });
   }
 
   move(srcPath: string, destPath: string) {