Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getBodyText() doesn't work as would be expected #1560

Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix: getBodyText() doesn't work as would be expected #1560

merged 1 commit into from
Oct 5, 2024

Conversation

jmyrick02
Copy link
Contributor

@jmyrick02 jmyrick02 commented Jul 25, 2024 •
edited
Loading

Fixes #1559

The first test corresponds to the first issue mentioned in #1559, which is definitely a bug. This is addressed by the addition of the new if statement at the end of the while loop. The second test corresponds to my preferred behavior of ignoring empty lines when adjusting indentation levels. This was addressed by the modification of the condition to update the minimum indent level. If you do not believe this should be default behavior, at least an option should be provided, since I'm finding it necessary for my use case.

Please let me know if you have any thoughts.

@dsherret dsherret added this to the 24.0.0 milestone Aug 25, 2024
dsherret
dsherret approved these changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit 81dc87d into dsherret:latest Oct 5, 2024
@jmyrick02
Copy link
Contributor Author

Thanks!

Thank you so much! This is my first real OSS contribution, so I appreciate this a lot. Thanks for being a maintainer.

renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 26, 2025
@renovate
chore(deps): update dependency ts-morph to v25
f21addb 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Jan 28, 2025
@renovate
chore(deps): update dependency ts-morph to v25
6dd66ca 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 1, 2025
@renovate
chore(deps): update dependency ts-morph to v25
15cb92b 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 2, 2025
@renovate
chore(deps): update dependency ts-morph to v25
e5d3560 
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 5, 2025
@renovate
chore(deps): update dependency ts-morph to v25
c07679d 
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.

getBodyText() doesn't work as would be expected
2 participants
@jmyrick02 @dsherret