fix: getDerivedClasses() isn't correct in some cases #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
added a commit
to mmkal/expect-type
that referenced
this pull request
Jan 26, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0) #### What's Changed - feat: TypeScript 5.7.2 dsherret/ts-morph#1594 - fix: switch back to fast-glob for stability dsherret/ts-morph#1595 - fix: properly insert async keyword in arrow function dsherret/ts-morph#1597 - fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598 - fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599 **Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0 ##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0) #### What's Changed - perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549 - perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558 - fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557 - fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560 - feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576 #### New Contributors - [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549 - [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557 **Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot
added a commit
to mmkal/expect-type
that referenced
this pull request
Jan 28, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0) #### What's Changed - feat: TypeScript 5.7.2 dsherret/ts-morph#1594 - fix: switch back to fast-glob for stability dsherret/ts-morph#1595 - fix: properly insert async keyword in arrow function dsherret/ts-morph#1597 - fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598 - fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599 **Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0 ##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0) #### What's Changed - perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549 - perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558 - fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557 - fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560 - feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576 #### New Contributors - [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549 - [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557 **Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot
added a commit
to mmkal/expect-type
that referenced
this pull request
Feb 1, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0) #### What's Changed - feat: TypeScript 5.7.2 dsherret/ts-morph#1594 - fix: switch back to fast-glob for stability dsherret/ts-morph#1595 - fix: properly insert async keyword in arrow function dsherret/ts-morph#1597 - fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598 - fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599 **Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0 ##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0) #### What's Changed - perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549 - perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558 - fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557 - fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560 - feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576 #### New Contributors - [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549 - [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557 **Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot
added a commit
to mmkal/expect-type
that referenced
this pull request
Feb 2, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0) #### What's Changed - feat: TypeScript 5.7.2 dsherret/ts-morph#1594 - fix: switch back to fast-glob for stability dsherret/ts-morph#1595 - fix: properly insert async keyword in arrow function dsherret/ts-morph#1597 - fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598 - fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599 **Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0 ##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0) #### What's Changed - perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549 - perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558 - fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557 - fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560 - feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576 #### New Contributors - [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549 - [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557 **Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate bot
added a commit
to mmkal/expect-type
that referenced
this pull request
Feb 5, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1) ##### Bug Fixes - bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0)) - update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097)) ##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0) #### What's Changed - feat: TypeScript 5.7.2 dsherret/ts-morph#1594 - fix: switch back to fast-glob for stability dsherret/ts-morph#1595 - fix: properly insert async keyword in arrow function dsherret/ts-morph#1597 - fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598 - fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599 **Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0 ##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0) #### What's Changed - perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549 - perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558 - fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557 - fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560 - feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576 #### New Contributors - [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549 - [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557 **Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556
I'm unsure if the test is desirable since it imports
Project. I wasn't sure how to test the fix without creating aProject. Let me know.