chore(devcontainer): update image: v1.0.6 #2802
Conversation
WalkthroughOhayo, sensei! This pull request introduces updates to the Docker image version in various configuration files related to a Rust development environment. The image version has been incremented from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/ci.yml (2)
Line range hint
98-106: Consider enhancing the Katana process health check, sensei!While adding a process health check is valuable, the current implementation using
sleepcould be more robust. Consider:
- Adding a timeout to prevent hanging
- Using a more reliable way to check process readiness (e.g., checking API endpoint)
Here's a suggested improvement:
- ./katana & - KATANA_PID=$! - sleep 2 - if ! kill -0 $KATANA_PID; then - echo "Katana exited with an error" - exit 1 - fi - kill $KATANA_PID + ./katana & + KATANA_PID=$! + TIMEOUT=30 + while [ $TIMEOUT -gt 0 ]; do + if curl -s http://127.0.0.1:5050 >/dev/null; then + echo "Katana is ready" + kill $KATANA_PID + exit 0 + fi + sleep 1 + TIMEOUT=$((TIMEOUT-1)) + done + echo "Katana failed to start within timeout" + kill $KATANA_PID + exit 1🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Ohayo! The Hurl version needs an update, sensei!
The workflow is using Hurl 3.0.0, but the latest stable version is 6.0.0. This significant version gap might include important bug fixes and improvements.
- Update the Hurl installation command in
.github/workflows/ci.yml:- curl --location --remote-name https://github.com/Orange-OpenSource/hurl/releases/download/3.0.0/hurl_3.0.0_amd64.deb + curl --location --remote-name https://github.com/Orange-OpenSource/hurl/releases/download/6.0.0/hurl_6.0.0_amd64.deb - sudo apt update && sudo apt install ./hurl_3.0.0_amd64.deb + sudo apt update && sudo apt install ./hurl_6.0.0_amd64.deb🔗 Analysis chain
Line range hint
183-201: Ohayo! Let's verify the Hurl version and improve process management.
The Hurl version is pinned to 3.0.0. Let's verify this is the latest stable version:
The Katana process management could be improved:
- nohup /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee & + # Start Katana and wait for it to be ready + /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee > katana.log 2>&1 & + KATANA_PID=$! + echo "Waiting for Katana to be ready..." + TIMEOUT=30 + while [ $TIMEOUT -gt 0 ]; do + if curl -s http://127.0.0.1:5050 >/dev/null; then + echo "Katana is ready" + break + fi + sleep 1 + TIMEOUT=$((TIMEOUT-1)) + if ! kill -0 $KATANA_PID 2>/dev/null; then + echo "Katana process died unexpectedly" + cat katana.log + exit 1 + fi + done + if [ $TIMEOUT -eq 0 ]; then + echo "Katana failed to start within timeout" + cat katana.log + exit 1 + fi🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check latest Hurl release version gh api repos/Orange-OpenSource/hurl/releases/latest --jq .tag_nameLength of output: 74
🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(7 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- .github/workflows/release-dispatch.yml
- .devcontainer/devcontainer.json
- .github/workflows/bench.yml
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
34-34: Ohayo sensei! Docker image version updates look consistent.
The Docker image version has been consistently updated to v1.0.6 across all jobs in the workflow.
Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
=======================================
Coverage 55.75% 55.75%
=======================================
Files 439 439
Lines 55572 55572
=======================================
Hits 30982 30982
Misses 24590 24590 ☔ View full report in Codecov by Sentry. |
Update devcontainer image: v1.0.6 Co-authored-by: glihm <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
katanaprocess in the CI workflow.