Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devcontainer): update image: v1.0.5 #2775

Merged
merged 1 commit into from
Dec 6, 2024
Merged

chore(devcontainer): update image: v1.0.5 #2775

merged 1 commit into from
Dec 6, 2024

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Dec 6, 2024

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features

    • Updated Docker image version to v1.0.5 across various workflows to enhance development and CI processes.
  • Chores

    • Modified Docker image version in the development container configuration.
    • Updated image version in benchmarking and CI workflow configurations.

Copy link

coderabbitai bot commented Dec 6, 2024

Walkthrough

Ohayo, sensei! This pull request primarily updates the Docker image version used across various configuration files related to Rust development and CI workflows. The image version has been changed from v1.0.4 to v1.0.5 in the .devcontainer/devcontainer.json, .github/workflows/bench.yml, .github/workflows/ci.yml, and .github/workflows/release-dispatch.yml files. No other structural changes or modifications to job configurations have been made.

Changes

File Path Change Summary
.devcontainer/devcontainer.json Updated image version from v1.0.4 to v1.0.5.
.github/workflows/bench.yml Updated image version from v1.0.4 to v1.0.5 in bench-katana and bench-sozo jobs.
.github/workflows/ci.yml Updated image version from v1.0.4 to v1.0.5 across multiple jobs: test, ensure-wasm, dojo-core-test, dojo-spawn-and-move-example-test, clippy, fmt, docs, and ensure-docker.
.github/workflows/release-dispatch.yml Updated image version from v1.0.4 to v1.0.5 in propose-release job.

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c5e7d6b and 3ebd280.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .github/workflows/bench.yml (2 hunks)
  • .github/workflows/ci.yml (7 hunks)
  • .github/workflows/release-dispatch.yml (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • .devcontainer/devcontainer.json
  • .github/workflows/bench.yml
  • .github/workflows/release-dispatch.yml
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

34-34: Ohayo sensei! Let's verify the new Docker image version.

The Docker image version has been consistently updated to v1.0.5 across all jobs. While the change looks good, let's verify that this version exists and is properly tagged.

Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175

✅ Verification successful

Ohayo sensei! The Docker image version v1.0.5 is verified and good to go!

The API response confirms that:

  • The image ghcr.io/dojoengine/dojo-dev:v1.0.5 exists and was published on December 6, 2024
  • It is also tagged as latest, indicating it's the most recent version
  • This is indeed the latest versioned tag available for this image
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Docker image version exists and check its details

# Check if the image exists and get its details
gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/orgs/dojoengine/packages/container/dojo-dev/versions" | \
  jq '.[] | select(.metadata.container.tags[] | contains("v1.0.5"))'

# Get the latest available version for comparison
gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/orgs/dojoengine/packages/container/dojo-dev/versions" | \
  jq -r '.[0].metadata.container.tags[]' | \
  grep "^v[0-9]"

Length of output: 1026


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.02%. Comparing base (c5e7d6b) to head (3ebd280).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   56.01%   56.02%           
=======================================
  Files         434      434           
  Lines       55068    55068           
=======================================
+ Hits        30849    30851    +2     
+ Misses      24219    24217    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 484b7da into main Dec 6, 2024
14 checks passed
@glihm glihm deleted the bump-devcontainer branch December 6, 2024 17:00
Larkooo pushed a commit to Larkooo/dojo that referenced this pull request Dec 9, 2024
Update devcontainer image: v1.0.5

Co-authored-by: glihm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants