Update devcontainer image: v1.0.0-rc.0 #2584
Conversation
WalkthroughOhayo, sensei! This pull request includes updates across several configuration files to change the Docker image version from Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
.devcontainer/devcontainer.json (1)
Line range hint
1-2: Ohayo sensei! Minor documentation update suggestion.The referenced version in the header comment (
v0.245.2) appears to be outdated. Consider updating this documentation link in a future PR to reflect the current version of vscode-dev-containers..github/workflows/ci.yml (2)
Line range hint
95-103: Consider increasing the wait time for Katana startup, sensei!The 2-second sleep might be too short for some CI environments. Consider increasing it to 5-10 seconds to ensure Katana has fully initialized before checking its status.
- sleep 2 + sleep 5🧰 Tools
🪛 actionlint
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
Line range hint
189-205: Consider using version variables for better maintainability, sensei!The hurl version (3.0.0) is hardcoded. Consider moving it to the env section at the top of the workflow file, similar to how RUST_VERSION is managed.
env: CARGO_TERM_COLOR: always RUST_VERSION: 1.79.0 + HURL_VERSION: 3.0.0Then update the installation command:
- curl --location --remote-name https://github.com/Orange-OpenSource/hurl/releases/download/3.0.0/hurl_3.0.0_amd64.deb + curl --location --remote-name https://github.com/Orange-OpenSource/hurl/releases/download/${HURL_VERSION}/hurl_${HURL_VERSION}_amd64.deb🧰 Tools
🪛 actionlint
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
- .devcontainer/devcontainer.json (1 hunks)
- .github/workflows/bench.yml (2 hunks)
- .github/workflows/ci.yml (8 hunks)
- .github/workflows/release-dispatch.yml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .github/workflows/bench.yml
- .github/workflows/release-dispatch.yml
🔇 Additional comments (3)
.devcontainer/devcontainer.json (1)
5-5: Ohayo sensei! Let's verify the new image version.The bump from
v1.0.0-alpha.17tov1.0.0-alpha.19looks good, but let's ensure the image is available.✅ Verification successful
Ohayo sensei! The image version is valid and ready to use!
The Docker image
ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.19exists in the registry and is also tagged aslatest, confirming it's the most recent version. The version bump is safe to proceed with.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new Docker image exists and is accessible # Expected: The image should be found and its details should be displayed # Test: Check if the image exists in the container registry gh api \ -H "Accept: application/vnd.oci.image.index.v1+json" \ /orgs/dojoengine/packages/container/dojo-dev/versions \ | jq -r '.[] | select(.metadata.container.tags[] | contains("v1.0.0-alpha.19"))'Length of output: 384
Script:
#!/bin/bash # Let's try a different approach using the GitHub API to check package versions gh api \ -H "Accept: application/vnd.github+json" \ /orgs/dojoengine/packages/container/dojo-dev/versions \ | jq -r '.[] | select(.metadata.container.tags[] | contains("v1.0.0-alpha.19")) | .metadata.container.tags[]' # Also let's check if we can find any references to this version in the repository rg -i "v1.0.0-alpha.19" --type json --type yamlLength of output: 284
.github/workflows/ci.yml (2)
34-34: Ohayo! Docker image version updates look consistent, sensei!The Docker image version has been consistently updated to
v1.0.0-alpha.19across all jobs in the workflow.Also applies to: 59-59, 124-124, 139-139, 153-153, 162-162, 171-171, 180-180
Line range hint
38-52: Excellent test configuration, sensei!The test job is well structured with proper artifact handling, binary setup, and coverage reporting. The use of
llvm-covwith codecov integration is a great practice for maintaining code quality.🧰 Tools
🪛 actionlint
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
tarrencev
force-pushed
the
bump-devcontainer
branch
from
b6e33a2 to
f23f29a
Compare
tarrencev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
+ Coverage 55.13% 55.14% +0.01%
==========================================
Files 385 385
Lines 47748 47748
==========================================
+ Hits 26325 26330 +5
+ Misses 21423 21418 -5 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
test-hurlin the CI workflow to enhance testing capabilities.ensure-dockerjob with a check for thekatanaprocess.testjob to download thedojo-binsartifact for subsequent commands.