Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadolint: fix color output and stdin shown as "-" #3680

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

infokiller
Copy link
Contributor

@infokiller infokiller commented Apr 5, 2021

I started working on using the hadolint json format instead, but I'm blocked on
an upstream issue: hadolint/hadolint#593

@infokiller
Copy link
Contributor Author

The issue was fixed quickly, should I send the other PR to use the json output instead of this one?

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Thanks.

@hsanson hsanson merged commit 686c8c5 into dense-analysis:master Apr 10, 2021
@hsanson
Copy link
Contributor

hsanson commented Apr 10, 2021

@infokiller JSON output support seems very recent. Another PR to support it when available would be good as long as it does not break current tool support.

@infokiller infokiller deleted the hadolint-fix-stdin branch April 10, 2021 15:47
jsit added a commit to jsit/ale that referenced this pull request Apr 19, 2021
* origin/master: (219 commits)
  Updated `solhint` linter to be able to use a local installation (dense-analysis#3682)
  Don't exit visual mode on floating preview close (dense-analysis#3689)
  hadolint: fix color output and stdin shown as "-" (dense-analysis#3680)
  feat: Add protolint as linter and fixer (dense-analysis#2911)
  apple-swift-format: linter and fixer with config swiftpm support (dense-analysis#3671)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants