Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Re-organise tests #3633

Closed
w0rp opened this issue Mar 15, 2021 · 2 comments
Closed

Chore: Re-organise tests #3633

w0rp opened this issue Mar 15, 2021 · 2 comments
Assignees
Milestone

Comments

@w0rp
Copy link
Member

w0rp commented Mar 15, 2021

I want to re-organise the test files a bit to make some filenames simpler and put all of the additional test files into one place so they don't clutter the Vader test files directories as much. The new structure should look like so:

test/vimrc           # The vimrc for running tests in Docker
test/script/         # Scripts for running tests
test/test-files/     # All dummy files for checking path searching go in here
test/linter/         # Linter command tests go in here
test/fixer/          # Fixer command tests go in here
test/handler/        # Linter problem handlers go in here
test/lsp/            # LSP feature tests go in here
test/...             # Other directories and .vader files...

I want to simplify the Vader filenames. Linter tests like test_zig_zls_callbacks.vader should be named test_zig_zls.vader instead, and fixer tests like test_terraform_fmt_fixer_callback.vader should be named test_terraform_fmt.vader instead. The handler tests can retain their _handler.vader filenames so they are easy to tell apart from linter command tests just by looking at the base names of the test files.

@w0rp w0rp self-assigned this Mar 15, 2021
w0rp added a commit that referenced this issue Mar 21, 2021
jsit added a commit to jsit/ale that referenced this issue Mar 30, 2021
* master: (214 commits)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  Fix ale#path#Dirname on Windows
  Disable blank issues and add a link to ask for help
  Check user systemd unit files with systemd-analyze
  Close dense-analysis#2102 - Add support for the Angular language server
  Fix texlab#GetProjectRoot (dense-analysis#3610)
  ...
jsit added a commit to jsit/ale that referenced this issue Apr 19, 2021
* origin/master: (219 commits)
  Updated `solhint` linter to be able to use a local installation (dense-analysis#3682)
  Don't exit visual mode on floating preview close (dense-analysis#3689)
  hadolint: fix color output and stdin shown as "-" (dense-analysis#3680)
  feat: Add protolint as linter and fixer (dense-analysis#2911)
  apple-swift-format: linter and fixer with config swiftpm support (dense-analysis#3671)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  ...
@w0rp w0rp added this to the Version 4.0.0 milestone Feb 13, 2023
@w0rp
Copy link
Member Author

w0rp commented Feb 13, 2023

@hsanson I'll try to finally complete this for 4.0.0. I'm also considering doing a trick with find where we automatically determine the depth .vader files lie at and use that to generate the glob arguments for .vader files. We need to pass globs for test files because the command line string will be too long if we specify each individual file, but I can imagine the Bash script code in my head that would generate any depth of globs using only * and not **. I'll avoid ** so the scripts still work with Bash 3. (Mac OSX...)

@w0rp
Copy link
Member Author

w0rp commented Sep 8, 2023

This should be pretty much the structure we use now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant