Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protolint linter and fixer #2911

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

yoheimuta
Copy link
Contributor

This PR adds protolint as a linter and a fixer for Protocol Buffer.

@yoheimuta
Copy link
Contributor Author

That works like the following.

vim-protolint-2

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good and simple. 👍

@yoheimuta
Copy link
Contributor Author

@hsanson ( @w0rp ) Thank you for your review!
Is something lacking in this pull request still?

@hsanson
Copy link
Contributor

hsanson commented Jan 9, 2020

Be patient until the PR is merged by someone with merge privileges. I myself have several PR's waiting to be merged.

@yoheimuta
Copy link
Contributor Author

Thank you for your information.
I understand.

@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Aug 13, 2020
@stale stale bot closed this Aug 15, 2020
@wwuck
Copy link

wwuck commented Apr 8, 2021

@hsanson How do we reopen this PR and get it merged? It would be nice to have automatic support for protolint inside ale.

@hsanson hsanson reopened this Apr 9, 2021
@stale stale bot removed the stale PRs/Issues no longer valid label Apr 9, 2021
@hsanson hsanson merged commit cec9954 into dense-analysis:master Apr 9, 2021
@hsanson
Copy link
Contributor

hsanson commented Apr 9, 2021

@wwuck thanks for the reminder.

afranioce pushed a commit to afranioce/ale that referenced this pull request Apr 10, 2021
jsit added a commit to jsit/ale that referenced this pull request Apr 19, 2021
* origin/master: (219 commits)
  Updated `solhint` linter to be able to use a local installation (dense-analysis#3682)
  Don't exit visual mode on floating preview close (dense-analysis#3689)
  hadolint: fix color output and stdin shown as "-" (dense-analysis#3680)
  feat: Add protolint as linter and fixer (dense-analysis#2911)
  apple-swift-format: linter and fixer with config swiftpm support (dense-analysis#3671)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants