Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: cleanup #527

Merged
merged 4 commits into from
Sep 18, 2019
Merged

multi: cleanup #527

merged 4 commits into from
Sep 18, 2019

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Sep 13, 2019

No description provided.

@dajohi dajohi added this to the v1.2.0 milestone Sep 13, 2019
itswisdomagain
itswisdomagain reviewed Sep 13, 2019
View reviewed changes
system/core.go Outdated Show resolved Hide resolved
JoeGruffins
JoeGruffins approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places where errors will now cause different behavior, as they were previously ignored, but testing around those areas hasn't caused any issues for me.

controllers/main.go Show resolved Hide resolved
server.go Show resolved Hide resolved
jholdstock
jholdstock requested changes Sep 16, 2019
View reviewed changes
server.go Show resolved Hide resolved
controllers/main.go Outdated Show resolved Hide resolved
controllers/main.go Outdated Show resolved Hide resolved
controllers/main.go Outdated Show resolved Hide resolved
controllers/main.go Show resolved Hide resolved
@jholdstock jholdstock mentioned this pull request Sep 16, 2019
Merged
@dajohi dajohi merged commit 1e241f9 into decred:master Sep 18, 2019
girino added a commit to girino/dcrstakepool that referenced this pull request Sep 19, 2019
@girino
Merge commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d'
faffebb 
* commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d':
  Add 1.2.0 release note. (decred#509)
  multi: cleanup (decred#527)
  Ensure low fee tickets are detected upon maturation. (decred#524)
  Add RPC automatic reconnections (decred#510)
  Prevent unnecessary wallet rescans. (decred#519)
  enablevoting=0 in dcrwallet conf (decred#520)
  stakepoold: Stop if wallet voting is enabled (decred#523)
jyap808 pushed a commit to ubiq/dcrstakepool that referenced this pull request Dec 16, 2019
@dajohi @jyap808
multi: cleanup (decred#527)
7ea9d13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itswisdomagain itswisdomagain itswisdomagain left review comments

@marcopeereboom marcopeereboom marcopeereboom approved these changes

@jholdstock jholdstock jholdstock approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dajohi @marcopeereboom @jholdstock @itswisdomagain @JoeGruffins