Prevent unnecessary wallet rescans. #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is acheived by adding a new stakepoold RPC. Previously we used a single RPC to import redeem scripts, regardless of whether they were new or historic. A rescan was triggered every time a script was imported. This was problematic because on startup, dcrstakepool performs consistency checks against each back-end and may import multiple scripts into a single wallet simultaneously. I have split the `ImportScript` RPC into two `ImportNewScript` and `ImportMissingScripts`. `ImportNewScript` will never trigger a rescan because a new script should have no associated history. This is used when a new wallet is connected to the VSP. `ImportMissingScripts` is used by the consistency checks, and will import multiple scripts before triggering a single rescan.
Merged
JoeGruffins
reviewed
Sep 10, 2019
| return -1, err | ||
| } | ||
| return block, nil | ||
| } | ||
|
|
||
| func (ctx *AppContext) ImportMissingScripts(scripts [][]byte, rescanHeight int) error { | ||
|
|
There was a problem hiding this comment.
Do you think it's worth checking that len(scripts) != 0 since it could cause a panic? I do realize that you are checking before calling, but someone else may not.
There was a problem hiding this comment.
Hmm, we don't currently have any request validation for the stakepoold RPC server, and I would be reluctant to add it for only one request. We should either add validation to all requests for consistency, or seeing as are controlling both the client and the server code, and seeing as we dont expect any additional clients, I think we could leave it as-is. Obviously we would be a bit more careful if this were a public API with external clients.
Happy to change if others disagree.
There was a problem hiding this comment.
Ok. Maybe just a comment then?
JoeGruffins
approved these changes
Sep 11, 2019
dajohi
approved these changes
Sep 12, 2019
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 19, 2019
* commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d': Add 1.2.0 release note. (decred#509) multi: cleanup (decred#527) Ensure low fee tickets are detected upon maturation. (decred#524) Add RPC automatic reconnections (decred#510) Prevent unnecessary wallet rescans. (decred#519) enablevoting=0 in dcrwallet conf (decred#520) stakepoold: Stop if wallet voting is enabled (decred#523)
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
* Prevent unnecessary wallet rescans. This is acheived by adding a new stakepoold RPC. Previously we used a single RPC to import redeem scripts, regardless of whether they were new or historic. A rescan was triggered every time a script was imported. This was problematic because on startup, dcrstakepool performs consistency checks against each back-end and may import multiple scripts into a single wallet simultaneously. I have split the `ImportScript` RPC into two `ImportNewScript` and `ImportMissingScripts`. `ImportNewScript` will never trigger a rescan because a new script should have no associated history. This is used when a new wallet is connected to the VSP. `ImportMissingScripts` is used by the consistency checks, and will import multiple scripts before triggering a single rescan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is acheived by adding a new stakepoold RPC. Previously we used a single RPC
to import redeem scripts, regardless of whether they were new or historic. A
rescan was triggered every time a script was imported. This was problematic
because on startup, dcrstakepool performs consistency checks against each
back-end and may import multiple scripts into a single wallet simultaneously.
I have split the
ImportScriptRPC into twoImportNewScriptandImportMissingScripts.ImportNewScriptwill never trigger a rescan because a new script should haveno associated history. This is used when a new wallet is connected to the VSP.
ImportMissingScriptsis used by the consistency checks, and will importmultiple scripts before triggering a single rescan.
Closes #517